Updating doc to set correct expectations when using restrictive XAML mode in WPF - #2278
Open
dipeshmsft wants to merge 2 commits into
Open
Updating doc to set correct expectations when using restrictive XAML mode in WPF#2278dipeshmsft wants to merge 2 commits into
dipeshmsft wants to merge 2 commits into
Conversation
…loper expectations
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WPF and .NET XAML Services security documentation by reverting the broader “loading untrusted markup” guidance introduced in PR #2261, while keeping and emphasizing guidance that clarifies what WPF’s restrictive XAML reader mode does—and does not—guarantee.
Changes:
- Removed the recently added “untrusted XAML/binary XAML/restrictive reader” guidance block from the .NET XAML Services security considerations article.
- Removed the “Loading Untrusted XAML, BAML, and XPS Content” section from the WPF security article.
- Added a focused “Restrictive XAML reader mode” subsection under the existing loose XAML sandboxing section to set expectations about process/boundary behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dotnet-desktop-guide/xaml-services/security-considerations.md | Reverts the PR #2261 guidance block and updates metadata date. |
| dotnet-desktop-guide/wpf/security-wpf.md | Removes the “untrusted markup” section, adds restrictive reader expectations, and refreshes the in-article section list. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverting the security guidance added in #2261 for loading untrusted XAML, BAML and XPS packages. Most of the added changes are redundant as the expectations for the above scenario is already present in the doc. However, retaining the doc changes on restrictive XAML reader mode in WPF as the latest findings suggested that lack of documentation regarding this mode is setting wrong expectations for the developers.
Internal previews