Skip to content

Enable Android dependency install test retries #12059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable Android dependency install test retries #12059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
489f484
Initial plan
Copilot Jul 13, 2026
4a5a8c7
Fix Android dependency install retry
Copilot Jul 13, 2026
29c22b9
Re-enable InstallAndroidDependenciesTest
jonathanpeppers Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ namespace Xamarin.Android.Build.Tests
public class AndroidDependenciesTests : BaseTest
{
[Test]
[Ignore ("Flaky test that intermittently fails when downloading the Android SDK/JDK over the network in CI. See: https://github.com/dotnet/android/issues/11973")]
[NonParallelizable] // Do not run environment modifying tests in parallel.
public void InstallAndroidDependenciesTest ([Values ("GoogleV2", "Xamarin")] string manifestType, [Values (AndroidRuntime.CoreCLR, AndroidRuntime.NativeAOT)] AndroidRuntime runtime)
{
Expand Down Expand Up @@ -63,6 +62,7 @@ public void InstallAndroidDependenciesTest ([Values ("GoogleV2", "Xamarin")] str
using (var b = CreateApkBuilder ()) {
b.Verbosity = LoggerVerbosity.Detailed;
b.CleanupAfterSuccessfulBuild = false;
b.ThrowOnBuildFailure = false;

@github-actions github-actions Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Testing — This is the correct fix: without it, Builder.Build throws FailedBuildException on the first failed attempt (Builder.cs:414), so the retry loop below could never reach attempts 2–3. One thing to be aware of: this disables throwing for the entire builder, including the final default-target build at line 121. That's still safe because that build is guarded by Assert.IsTrue (b.Build (...), "build should have succeeded."), so a real failure there is still surfaced. No change needed — just confirming the behavior is intentional.

(Rule: Verify retry/error-handling semantics)

string defaultTarget = b.Target;
b.Target = "InstallAndroidDependencies";
b.BuildLogFile = "install-deps.log";
Expand Down
Loading