Perf Tests | Default Config File - #4606
Open
benrr101 wants to merge 1 commit into
Open
Conversation
benrr101
added
the
Area\Engineering
Contributor
There was a problem hiding this comment.
Pull request overview
Moves performance-test configuration to a generated, locally editable file.
Changes:
- Adds a default runner configuration template.
- Generates and copies the live configuration during builds.
- Documents and ignores the local configuration file.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
runnerconfig.default.jsonc |
Provides the default configuration template. |
Microsoft.Data.SqlClient.PerformanceTests.csproj |
Generates and copies the live configuration. |
BUILDGUIDE.md |
Documents the new configuration workflow. |
.gitignore |
Excludes the local runner configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+28
to
+29
| <Target Name="CopyRunnerConfig" BeforeTargets="Compile"> | ||
| <Copy SourceFiles="runnerconfig.default.jsonc" DestinationFiles="runnerconfig.jsonc" Condition="!Exists('runnerconfig.jsonc')" /> |
Contributor
There was a problem hiding this comment.
I would suggest updating the run-perf-tests scripts to build, then look at the config, then dotnet run --no-build the benchmarks.
For the Kusto script, should the benchmark results contain the config file used? Then this script would be guaranteed to see the same config that produced the results.
paulmedynski
requested changes
Aug 27, 2026
github-project-automation
Bot
moved this from To triage
to Waiting for customer
in SqlClient Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I got annoyed that my changes to the runnerconfig file kept getting blown away when I'd switch branches. We don't have this problem with the manual tests project despite it having a config file. So, I instructed the 🤖 to mirror the pattern in the perf tests project. This moves the runnerconfig.jsonc file to the runnerconfig.default.jsonc, and adds targets to the perf test project to use the default config as the live config (if it doesn't exist already) and copy the live config to the build output. It then adds the live config file as a gitignore, to deter accidentally committing one's DB credentials.
Issues
N/A
Testing
Perf test pipeline should be reran to ensure that the changes play nice.