Save the document extensions configuration - #809
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Document.load() reads the extensions key from the document config but Document.save() only wrote settings and attributes, so any document with an extensions section (for example a custom item_validator) silently lost it the first time doorstop rewrote the config. save() now emits extensions when the document has any, mirroring how the attributes section is written only when non-empty. Closes doorstop-dev#681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #681
Document.load()reads theextensionskey from the document config, butDocument.save()only wrotesettingsandattributes— so a document with anextensionssection (e.g. a customitem_validator) silently lost it the first time doorstop rewrote the config.save()now emitsextensionswhen the document has any, mirroring howattributesis written only when non-empty.Regression test in
doorstop/core/tests/test_document.pyfails without the change and passes with it.