Repository navigation
Hold CI's coverage floors half a point under its figures - #108
Merged
Merged
Conversation
The anywhere floors in tests/coverage-floor.json were the August figures, between 5.8 and 71.1 points under what CI measures. Bws.Cli measured 80.5% over a floor of 9.5, so its tests could lose most of their coverage and the build would stay green. Seven CI runs on 2026-11-02 gave Bws.Core 90.1% and Bws.Gui 92% every time, and Bws.Cli 80.5% or 80.6%, both on one and the same tree. A floor equal to the figure would fail a build that changed nothing, so each floor sits half a point under the lowest figure: Bws.Core 89.6, Bws.Gui 91.5 and Bws.Cli 80.0. The header of the gate says why, and how to raise them again. The everything scope, measured on a developer's machine, is not touched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The
anywherefloors intests/coverage-floor.json, the ones CI holds in the step "coverage against its floor":A new paragraph in the header of
tests/coverage-gate.ps1says why the floors sit under the figures and how to raise them again. Theeverythingscope is not touched.Why
The floors were the August figures. With Bws.Cli at 80.5% over a floor of 9.5, its tests could lose most of their coverage and CI would stay green.
Why half a point and not the figure itself
The seven runs on 2026-11-02 cover four trees, and two runs on the same tree gave Bws.Cli 80.5% and 80.6%. Bws.Core and Bws.Gui held still in all seven. A floor equal to the figure would fail a build that changed nothing. Half a point is five times the movement seen. It still catches a loss of about 13 lines in Bws.Cli, 34 in Bws.Core and 45 in Bws.Gui.
Checked
pwsh -File tests/coverage-gate.ps1 -SelfTest: 7 of 7.okagainst the new floors.🤖 Generated with Claude Code