Repository navigation
Move coverlet.collector to 10.1.0 - #107
Conversation
The weekly outdated-package gate held coverlet at 6.0.4 until 2026-12-01, because the coverage floors are written to a tenth of a point and 10.1.0 says it counts auto-properties and records differently. This takes the move and drops the hold, which the gate would otherwise report as holding nothing. Measured with one narrow test per project under each version: the same lines are coverable in Bws.Core (6824), Bws.Gui (9026) and Bws.Cli (2594), which are also the counts the last CI run gave on every test. One line read differently, an executed continue statement in the command line reader that 10.1.0 reports as not hit. The report now writes its paths with forward slashes, and the coverage gate makes every path absolute before it compares them, so it groups the files as before. The last CI run was at least 5.8 points above every floor, so one line cannot turn the gate red. The full figures come from the run on this pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update test coverage collector tests/Bws.*.Tests/*.csproj, .github/outdated/held.toml, THIRD-PARTY-NOTICES.md |
The six test projects now reference coverlet.collector version 10.1.0. The hold entry was removed, and the notice lists version 10.1.0. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- donislawdev/BetterWindowsServices#106: Adds the hold for
coverlet.collectorversion 10.1.0 that this pull request removes.
Suggested labels: dependencies
Merge Risk: 
6cde8
-
No actionable merge-blocking issue is established. The dependency update is mergeable subject to normal build, test, and coverage checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main code change: upgrading coverlet.collector to version 10.1.0. It is specific, concise, and suitable for release notes or git history. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Tests For Changed Behavior The pull request changes only test-project dependency versions, a third-party notice, and an outdated-package hold. It does not change shipped runtime behavior. The diff deletes no tests and does not … No Secrets Or Debug Leftovers The pull request adds only six coverlet.collectorversion references and one notice-table row. It adds no private AI-agent files or.envfiles. Added lines contain no credentials, tokens, API keys…No Hardcoded Ui Styling The pull request changes only dependency metadata, project package versions, and the outdated-package hold. It does not change XAML, Slint, Fyne, Tkinter, WPF code-behind, or other GUI code. The check… No Obvious Performance Problems The pull request only updates the test-only coverlet.collector version, removes its outdated-package hold, and updates the notice table. It adds no runtime code, UI collection handling, loops, queries… Desktop Robustness The pull request changes only test-project package versions, a dependency notice, and an outdated-package hold. It adds no application code or behavior that loads working-directory assets, performs no… Safe File Parsing The PR changes only coverlet.collectorpackage versions, a third-party notice row, and removal of an outdated-package hold. It introduces no code that reads, imports, exports, deserializes, or write…System Changes Are Reversible The PR changes only test-project package references, a third-party notice, and an outdated-package hold. The diff adds no code that changes network filters, proxies, firewalls, system time, process st… Clear User-Facing Text PASS. The pull request changes package versions, removes an outdated-package hold, and updates one dependency version in THIRD-PARTY-NOTICES.md. It does not add or change application user-facing contr… No Resource Leaks The PR changes only coverlet.collectorversions in six non-packable test projects, removes an outdated-package hold, and updates the third-party notice. It adds no application code or resource-ownin…Scope, Duplication And Docs PASS. The authoritative diff contains only the coverlet.collector version update in six test projects, removal of its outdated-package hold, and the matching THIRD-PARTY-NOTICES entry. No unrelated re… Full details: Tests For Changed Behavior
-
Explanation
The pull request changes only test-project dependency versions, a third-party notice, and an outdated-package hold. It does not change shipped runtime behavior. The diff deletes no tests and does not skip tests or weaken assertions.
Full details: No Secrets Or Debug Leftovers
-
Explanation
The pull request adds only six
coverlet.collectorversion references and one notice-table row. It adds no private AI-agent files or.envfiles. Added lines contain no credentials, tokens, API keys, private URLs, local absolute paths, hostnames/IPs, personal e-mails, or debug calls.
Full details: No Hardcoded Ui Styling
-
Explanation
The pull request changes only dependency metadata, project package versions, and the outdated-package hold. It does not change XAML, Slint, Fyne, Tkinter, WPF code-behind, or other GUI code. The check is therefore not applicable.
Full details: No Obvious Performance Problems
-
Explanation
The pull request only updates the test-only coverlet.collector version, removes its outdated-package hold, and updates the notice table. It adds no runtime code, UI collection handling, loops, queries, polling, I/O, or computation that could create an explicit performance problem.
Full details: Desktop Robustness
-
Explanation
The pull request changes only test-project package versions, a dependency notice, and an outdated-package hold. It adds no application code or behavior that loads working-directory assets, performs non-atomic file I/O, uses culture-sensitive persistence, starts uncancellable work, adds destructive actions, leaves background work running, requests admin rights, or makes undisclosed network calls.
Full details: Safe File Parsing
-
Explanation
The PR changes only
coverlet.collectorpackage versions, a third-party notice row, and removal of an outdated-package hold. It introduces no code that reads, imports, exports, deserializes, or writes XML, XAML, CSV, XLSX, JSON, YAML, translation, theme, settings, or archive files. The safe file parsing check is not applicable.
Full details: System Changes Are Reversible
-
Explanation
The PR changes only test-project package references, a third-party notice, and an outdated-package hold. The diff adds no code that changes network filters, proxies, firewalls, system time, process state, Windows services, registry, or drivers. The reversibility requirements do not apply.
Full details: Clear User-Facing Text
-
Explanation
PASS. The pull request changes package versions, removes an outdated-package hold, and updates one dependency version in THIRD-PARTY-NOTICES.md. It does not add or change application user-facing controls, labels, tooltips, confirmations, or error messages. The notice keeps the same package name, licence, and description.
Full details: No Resource Leaks
-
Explanation
The PR changes only
coverlet.collectorversions in six non-packable test projects, removes an outdated-package hold, and updates the third-party notice. It adds no application code or resource-owning lifecycle such as handlers, timers, streams, processes, tasks, caches, or images. No resource leak is introduced by the changed files.
Full details: Scope, Duplication And Docs
-
Explanation
PASS. The authoritative diff contains only the coverlet.collector version update in six test projects, removal of its outdated-package hold, and the matching THIRD-PARTY-NOTICES entry. No unrelated refactor, duplicated functionality, architecture bypass, user-facing behavior, CLI/configuration change, or incompatible public API change is present.】【。
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
What changes
coverlet.collectorgoes from 6.0.4 to 10.1.0 in the six test projects. The hold in.github/outdated/held.tomlis removed and the row inTHIRD-PARTY-NOTICES.mdis updated.Why now
The weekly outdated-package gate held 10.1.0 until 2026-12-01. The coverage floors in
tests/coverage-floor.jsonare written to a tenth of a point, and the 10.1.0 notes say auto-properties and records are counted differently. A hold that holds nothing turns the gate red, so the hold goes in the same change.Measured before the push
One narrow test per project, with the same filter under each version, in Debug as the gate runs:
continue;insrc/Bws.Cli/CommandLine.Reading.cs, which 10.1.0 reports as not hit. The lines before it were hit twice under both versions.maingave with every test.outdated_gate.py verdicton this tree reports 0 behind, 0 held, 1 cooling and 8 current. Its self-test passes 75 of 75.What the run on this pull request decides
The full coverage figures, in the step "coverage against its floor".
🤖 Generated with Claude Code
Summary by CodeRabbit