Cover exception callbacks on the TaskFlow context - #26
Merged
Conversation
dombrovsky
marked this pull request as ready for review
August 17, 2026 01:30
dombrovsky
force-pushed
the
fix/14-exception-callback-context
branch
from
August 17, 2026 01:40
10c50df to
18a88dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnErrorcallbacksWhy
OnErrorpreviously observed failures after the terminal scheduler had completed, so callbacks forDedicatedThreadTaskFlowran without the flow synchronization context. PR #25 introduces completion middleware inside the terminal execution envelope; this stacked PR adds the focused public-behavior coverage needed for #14.Impact
This PR is test-only and depends on #25. No production API or implementation changes are added here.
Validation
Closes #14