Repository navigation
ShadowUtil: preserve the shadow request position snapshot - #214
Closed
KakarottoCake wants to merge 2 commits into
Closed
KakarottoCake wants to merge 2 commits into
KakarottoCake wants to merge 2 commits into
Conversation
Report for GMSP01 (2df38b9 - b493961)📈 Matched code: 42.11% (+0.12%, +4116 bytes) ✅ 12 new matches
📈 2 improvements in unmatched items
Report for GMSJ01 (2df38b9 - b493961)📈 Matched code: 43.06% (+0.11%, +4116 bytes) ✅ 13 new matches
📈 1 improvement in an unmatched item
|
KakarottoCake
changed the title
Collaborator
|
no, this needs to be fixed in objdiff |
Contributor
Author
|
Reverted the class-scope and symbol-name changes in af94cd6. The classes remain local to their original functions. Tested encounter/objdiff#411 at b20fe455: all 40 ShadowUtil functions are compared, 30 match exactly, and code progress is 32.67% with no symbol mappings or source renaming. The objdiff-core tests pass. The reporting fix still needs to land in objdiff and reach decomp.dev. |
KakarottoCake
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the position snapshot in forceRequest's copied shadow request.
The class-scope and symbol-name changes were reverted in af94cd6 after review.
The display-list classes remain local to their original functions, with the original target symbol names.
The grey display-list blocks are an objdiff symbol-pairing issue.
Tested encounter/objdiff#411 at b20fe455 with the original source scopes and no symbol mappings: all 40 functions are compared, 30 match exactly, code progress is 32.67%, and fuzzy code is 99.25%.
The reporting fix is pending in objdiff; this SMS PR remains closed.