Skip to content

PrintWindow: Implementation of the class. - #55

Merged
SwareJonge merged 1 commit into
doldecomp:mainfrom
cristian64:printwindow
Aug 2, 2026
Merged

PrintWindow: Implementation of the class.#55
SwareJonge merged 1 commit into
doldecomp:mainfrom
cristian64:printwindow

Conversation

@cristian64

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Jul 26, 2026

Copy link
Copy Markdown

Report for MarioClub_us (a2f28da - dba8e24)

📈 Matched code: 46.00% (+0.14%, +4404 bytes)
📈 Linked code: 40.30% (+0.14%, +4404 bytes)
📈 Matched data: 23.93% (+0.01%, +64 bytes)
📈 Linked data: 31.16% (+0.06%, +536 bytes)

✅ 7 new matches
Unit Item Bytes Before After
main/Kameda/PrintWindow PrintWindow::calc() +1784 0.22% 100.00%
main/Kameda/PrintWindow PrintWindow::PrintWindow(JKRHeap*) +1776 0.22% 100.00%
main/Kameda/PrintWindow PrintWindow::getBaseFontSize() +305 1.30% 100.00%
main/Kameda/PrintWindow PrintWindow::getTextBox() +269 1.47% 100.00%
main/Kameda/PrintWindow PrintWindow::init() +173 2.27% 100.00%
main/Kameda/PrintWindow PrintWindow::draw() +76 5.00% 100.00%
main/Kameda/PrintWindow .sdata2 +64 0.00% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/Kameda/PrintWindow .rodata +130 71.74% 99.25%

Comment thread src/Kameda/PrintWindow.cpp Outdated
Comment thread src/Kameda/PrintWindow.cpp Outdated
@cristian64
cristian64 force-pushed the printwindow branch 15 times, most recently from fed8717 to 4793dc5 Compare August 1, 2026 10:42
@cristian64
cristian64 marked this pull request as ready for review August 1, 2026 10:45
Comment thread src/Kameda/PrintWindow.cpp Outdated
Comment thread src/Kameda/PrintWindow.cpp Outdated
Comment thread include/Kameda/PrintWindow.h Outdated

@SwareJonge SwareJonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a big issue but some really small things that maybe could be changed/improved

@cristian64

Copy link
Copy Markdown
Contributor Author

Not really a big issue but some really small things that maybe could be changed/improved

Reasonable requests; updated now.

@SwareJonge
SwareJonge merged commit bd256c1 into doldecomp:main Aug 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants