Skip to content

Expand collation testing for $lookup stage #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielfrankcom wants to merge 3 commits into
base: main
Choose a base branch
from
+715 −9
Open

Expand collation testing for $lookup stage #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0be672
Expand collation testing for $lookup stage
danielfrankcom Jul 21, 2026
71d1c69
Add concise-form and index collation coverage
danielfrankcom Jul 21, 2026
61e8cf3
Add foreign-collation-ignored coverage
danielfrankcom Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 194 additions & 9 deletions ...entdb_tests/compatibility/tests/core/collation/command_level/stages/test_stages_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ class LookupCollationTestCase(LookupTestCase):
),
]

# Property [Lookup Pipeline Collation Propagation]: collation propagates into
# the pipeline form of $lookup so that sub-pipeline expressions inherit
# command-level collation.
COLLATION_LOOKUP_PIPELINE_TESTS: list[LookupCollationTestCase] = [
# Property [Lookup Verbose Collation Propagation]: collation propagates into
Comment thread
danielfrankcom marked this conversation as resolved.
# the verbose form of $lookup (let + pipeline) so that sub-pipeline stages,
# both $expr matches and ordering, inherit command-level collation.
COLLATION_LOOKUP_VERBOSE_TESTS: list[LookupCollationTestCase] = [
LookupCollationTestCase(
"lookup_pipeline_strength1_case_insensitive",
"lookup_verbose_strength1_case_insensitive",
docs=[{"_id": 1, "product": "Apple"}, {"_id": 2, "product": "banana"}],
foreign_docs=[{"_id": 1, "name": "apple"}, {"_id": 2, "name": "Banana"}],
pipeline=[
Expand All @@ -107,10 +107,10 @@ class LookupCollationTestCase(LookupTestCase):
{"_id": 1, "product": "Apple", "matched": [{"_id": 1, "name": "apple"}]},
{"_id": 2, "product": "banana", "matched": [{"_id": 2, "name": "Banana"}]},
],
msg="$lookup pipeline form with strength 1 should inherit collation",
msg="$lookup verbose form with strength 1 should inherit collation",
),
LookupCollationTestCase(
"lookup_pipeline_no_collation_binary",
"lookup_verbose_no_collation_binary",
docs=[{"_id": 1, "product": "Apple"}, {"_id": 2, "product": "banana"}],
foreign_docs=[{"_id": 1, "name": "apple"}, {"_id": 2, "name": "Banana"}],
pipeline=[
Expand All @@ -130,12 +130,197 @@ class LookupCollationTestCase(LookupTestCase):
{"_id": 1, "product": "Apple", "matched": []},
{"_id": 2, "product": "banana", "matched": []},
],
msg="$lookup pipeline form without collation should use binary comparison",
msg="$lookup verbose form without collation should use binary comparison",
),
LookupCollationTestCase(
"lookup_verbose_sort_case_insensitive",
docs=[{"_id": 1, "product": "apple"}],
foreign_docs=[{"_id": 10, "name": "Banana"}, {"_id": 11, "name": "apple"}],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"pipeline": [{"$sort": {"name": 1}}],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
command_collation={"locale": "en"},
expected=[
{
"_id": 1,
"product": "apple",
"matched": [{"_id": 11, "name": "apple"}, {"_id": 10, "name": "Banana"}],
}
],
msg="$lookup sub-pipeline $sort should order under command-level collation",
),
LookupCollationTestCase(
"lookup_verbose_sort_no_collation_binary",
docs=[{"_id": 1, "product": "apple"}],
foreign_docs=[{"_id": 10, "name": "Banana"}, {"_id": 11, "name": "apple"}],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"pipeline": [{"$sort": {"name": 1}}],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
expected=[
{
"_id": 1,
"product": "apple",
"matched": [{"_id": 10, "name": "Banana"}, {"_id": 11, "name": "apple"}],
}
],
msg="$lookup sub-pipeline $sort without collation should order by binary comparison",
),
]

# Property [Lookup Nested Sub-Pipeline Collation Propagation]: command-level
# collation propagates through a nested $lookup into the innermost sub-pipeline,
# so a deeply nested $expr comparison is collation-equal.
COLLATION_LOOKUP_NESTED_TESTS: list[LookupCollationTestCase] = [
Comment thread
danielfrankcom marked this conversation as resolved.
LookupCollationTestCase(
"lookup_nested_strength1_case_insensitive",
docs=[{"_id": 1, "product": "apple"}],
foreign_docs=[{"_id": 10, "name": "Apple"}],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"let": {"prod": "$product"},
"pipeline": [
{
"$lookup": {
"from": FOREIGN,
"pipeline": [
{"$match": {"$expr": {"$eq": ["$name", "$$prod"]}}},
],
"as": "inner",
}
},
],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
command_collation={"locale": "en", "strength": 1},
expected=[
{
"_id": 1,
"product": "apple",
"matched": [{"_id": 10, "name": "Apple", "inner": [{"_id": 10, "name": "Apple"}]}],
}
],
msg="$lookup nested sub-pipeline should inherit command-level collation "
"at the innermost level",
),
LookupCollationTestCase(
"lookup_nested_no_collation_binary",
docs=[{"_id": 1, "product": "apple"}],
foreign_docs=[{"_id": 10, "name": "Apple"}],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"let": {"prod": "$product"},
"pipeline": [
{
"$lookup": {
"from": FOREIGN,
"pipeline": [
{"$match": {"$expr": {"$eq": ["$name", "$$prod"]}}},
],
"as": "inner",
}
},
],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
expected=[
{
"_id": 1,
"product": "apple",
"matched": [{"_id": 10, "name": "Apple", "inner": []}],
}
],
msg="$lookup nested sub-pipeline without collation should use binary "
"comparison at the innermost level",
),
]

# Property [Lookup Concise Correlated Collation Propagation]: in the concise
# form (localField + foreignField + pipeline), command-level collation governs
# both the equality prefilter and the sub-pipeline comparisons.
COLLATION_LOOKUP_CONCISE_TESTS: list[LookupCollationTestCase] = [
LookupCollationTestCase(
"lookup_concise_strength1_case_insensitive",
docs=[{"_id": 1, "product": "Apple"}],
foreign_docs=[
{"_id": 10, "name": "apple", "tag": "KEEP"},
{"_id": 11, "name": "apple", "tag": "drop"},
],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"localField": "product",
"foreignField": "name",
"pipeline": [{"$match": {"tag": "keep"}}],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
command_collation={"locale": "en", "strength": 1},
expected=[
{
"_id": 1,
"product": "Apple",
"matched": [{"_id": 10, "name": "apple", "tag": "KEEP"}],
}
],
msg="$lookup concise form should apply command collation to both the "
"equality match and the sub-pipeline",
),
LookupCollationTestCase(
"lookup_concise_no_collation_binary",
docs=[{"_id": 1, "product": "Apple"}],
foreign_docs=[
{"_id": 10, "name": "apple", "tag": "KEEP"},
{"_id": 11, "name": "apple", "tag": "drop"},
],
pipeline=[
{
"$lookup": {
"from": FOREIGN,
"localField": "product",
"foreignField": "name",
"pipeline": [{"$match": {"tag": "keep"}}],
"as": "matched",
}
},
{"$sort": {"_id": 1}},
],
expected=[{"_id": 1, "product": "Apple", "matched": []}],
msg="$lookup concise form without collation should use binary comparison",
),
]

COLLATION_LOOKUP_TESTS: list[LookupCollationTestCase] = (
COLLATION_LOOKUP_EQUALITY_TESTS + COLLATION_LOOKUP_PIPELINE_TESTS
COLLATION_LOOKUP_EQUALITY_TESTS
+ COLLATION_LOOKUP_VERBOSE_TESTS
+ COLLATION_LOOKUP_NESTED_TESTS
+ COLLATION_LOOKUP_CONCISE_TESTS
)


Expand Down
Loading
Loading