Repository navigation
tests: isolate home paths and bind stream server to loopback - #3462
Open
mahekara28 wants to merge 1 commit into
Open
mahekara28 wants to merge 1 commit into
mahekara28 wants to merge 1 commit into
Conversation
Signed-off-by: Mahek Ara <mahekarabangi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining Windows test issues in #3335. The timezone fix is already in #3354.
The certificate and config tests now set both
HOMEandUSERPROFILEto the temporary directory. This fixes Windows home-directory lookup and lets the legacy.dockercfgtest run on Windows.The TCP test server now binds to
127.0.0.1, and the client connects to that address. The OS still picks a free port automatically.Validation on Windows (Python 3.11.16):
ruff check .andgit diff --checkpassed.Used Codex to draft the patch and description and run the local checks.
Created with: Codex