chore: replace sort.Slice with slices.SortFunc - #4034
Open
aheritier wants to merge 1 commit into
Open
Conversation
Replace 7 sort.Slice/sort.SliceStable calls with slices.SortFunc/ slices.SortStableFunc + cmp.Compare across 4 files. The slices package is more efficient (no reflection), type-safe, and idiomatic Go. The sort.Strings call sites are unchanged; "sort" is retained in files that still use it.
aheritier
marked this pull request as ready for review
August 22, 2026 16:02
aheritier
added
area/tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 7
sort.Slice/sort.SliceStablecalls withslices.SortFunc/slices.SortStableFunc+cmp.Compareacross 4 files.Why:
slices.SortFuncavoids reflection, is type-safe, and is the idiomatic API since Go 1.21 (no dependency on the Go 1.27 upgrade).Files changed:
pkg/tools/builtin/plan/plan.go— 1 callpkg/tools/builtin/mcpcatalog/mcpcatalog.go— 3 callspkg/sandbox/kit/kit.go— 2 callspkg/plans/service.go— 1 call (stable sort preserved viaSortStableFunc)Testing:
go build ./...,go teston all 4 touched packages,go vet,go run ./lint .,go mod tidy --diffall pass clean.