fix(#3996): keep image-output models eligible for session titles - #4021
Draft
aheritier wants to merge 1 commit into
Draft
fix(#3996): keep image-output models eligible for session titles#4021aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
Title generation is an explicitly text-only call, so image-output-capable models remain valid title candidates and may fall through to the next model on failure. Preserve title_model -> agent model -> fallbacks order, skip nil providers, and return nil only when no configured candidate remains. Apply the same construction behavior to LocalRuntime, the server session path, and the debug title command. Tests pin image-output candidate ordering, fallback, and isolation from the main generation stream.
aheritier
added
area/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Keeps image-output-capable models eligible for session-title generation while preserving the title-generation model filter and configuration behavior.
Why
Title generation should not discard otherwise valid models merely because they advertise image output.
Validation
task test; session-title, runtime, server, and configuration tests.Test instructions
Run:
task testConfigure an image-output-capable model and create a normal session that requires title generation. Expected: the model remains eligible for title generation, a title is produced, and the existing title-generation filtering behavior is preserved.