Skip to content

completion: fix zsh __docker_plugins bad math expression #7250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Aug 31, 2026
+6 −20
Merged

completion: fix zsh __docker_plugins bad math expression #7250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions contrib/completion/zsh/_docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,32 +1551,18 @@ __docker_plugin_complete_ls_filters() {
__docker_plugins() {
[[ $PREFIX = -* ]] && return 1
integer ret=1
local line s
local line name id
declare -a lines plugins args

filter=$1; shift
[[ $filter != "none" ]] && args=("-f $filter")
[[ $filter != "none" ]] && args=("-f" "$filter")

lines=(${(f)${:-"$(_call_program commands docker $docker_options plugin ls $args)"$'\n'}})

# Parse header line to find columns
local i=1 j=1 k header=${lines[1]}
declare -A begin end
while (( j < ${#header} - 1 )); do
i=$(( j + ${${header[$j,-1]}[(i)[^ ]]} - 1 ))
j=$(( i + ${${header[$i,-1]}[(i) ]} - 1 ))
k=$(( j + ${${header[$j,-1]}[(i)[^ ]]} - 2 ))
begin[${header[$i,$((j-1))]}]=$i
end[${header[$i,$((j-1))]}]=$k
done
end[${header[$i,$((j-1))]}]=-1
lines=(${lines[2,-1]})
lines=(${(f)${:-"$(_call_program commands docker $docker_options plugin ls --format '{{.Name}}\t{{.ID}}' $args)"$'\n'}})

# Name
for line in $lines; do
s="${line[${begin[NAME]},${end[NAME]}]%% ##}"
s="$s:${(l:7:: :::)${${line[${begin[TAG]},${end[TAG]}]}%% ##}}"
plugins=($plugins $s)
name="${line%%$'\t'*}"
id="${line#*$'\t'}"
plugins+=("${name//:/\\:}:$id")
done

_describe -t plugins-list "plugins" plugins "$@" && ret=0
Expand Down