docs(authz): clarify daemon parsing semantics#7086
Conversation
Signed-off-by: mickael emirkanian <mickael.emirkanian@docker.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
| > the request. The daemon decodes JSON **case-insensitively**, **last-one-wins**, | ||
| > and does not reject duplicate or case-variant keys. |
There was a problem hiding this comment.
We can also include https://pkg.go.dev/encoding/json#Unmarshal here as the exact implementation
There was a problem hiding this comment.
Yes, perhaps a good idea to refer to Go; potentially we can simplify the wording that plugin authors should use the same semantics as the daemon, which uses Go's json package?
| > the request. The daemon decodes JSON **case-insensitively**, **last-one-wins**, | ||
| > and does not reject duplicate or case-variant keys. |
There was a problem hiding this comment.
Yes, perhaps a good idea to refer to Go; potentially we can simplify the wording that plugin authors should use the same semantics as the daemon, which uses Go's json package?
There was a problem hiding this comment.
Wondering if we should put the additional information somewhere in this section (which looks to be focussed on "how to process request bodies"
There was a problem hiding this comment.
Moved the other section into the new one as it seemed better to me to have it in a higher-level section, but happy to move the new section into the existing one if you prefer.
Signed-off-by: mickael emirkanian <mickael.emirkanian@docker.com>
5 participants
- What I did
Clarify the daemon decoding semantics for access authorization plugins