progress: don't panic on --load writes after printer close - #4056
Open
locker95 wants to merge 1 commit into
Open
progress: don't panic on --load writes after printer close#4056locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
`--load` streams import progress into the build printer from a goroutine. If that load is still going when printer.Wait() closes the status channel, Write panics with send on closed channel. Wait for the loader closer during solve cleanup, and drop late Write calls instead of panicking. Fixes docker#3948 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--loadstreams "importing to docker" into the build printer from a goroutine. if that load is still going whenprinter.Wait()closes the status channel,Writepanics (send on closed channel).wait for the loader closer during solve cleanup, and drop late
Writes instead of panicking.Fixes #3948