Skip to content

test: isolate PR env in requireBumpFile ci check tests #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 1 commit into from
Oct 29, 2026
Merged

test: isolate PR env in requireBumpFile ci check tests #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/bumpy/test/core/check-require-bump-file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,28 @@ describe('requireBumpFile', () => {
});

describe('bumpy ci check', () => {
// Pin the PR env so the host CI's own PR (e.g. the version PR branch, which
// `ci check` skips) doesn't leak into these tests
const ENV_KEYS = [
'GITHUB_HEAD_REF',
'GITHUB_BASE_REF',
'BUMPY_PR_NUMBER',
'GITHUB_EVENT_NAME',
'GITHUB_EVENT_PATH',
];
let savedEnv: Record<string, string | undefined>;
beforeEach(() => {
savedEnv = Object.fromEntries(ENV_KEYS.map((k) => [k, process.env[k]]));
for (const k of ENV_KEYS) delete process.env[k];
process.env.GITHUB_HEAD_REF = 'feature';
});
afterEach(() => {
for (const [k, v] of Object.entries(savedEnv)) {
if (v === undefined) delete process.env[k];
else process.env[k] = v;
}
});

test('fails when a required package is uncovered, even with another bump file', async () => {
await commitBumpFiles({ 'app-change': "---\n'app': patch\n---\n\nFix app\n" });
expect(await run(() => ciCheckCommand(tmpDir, { comment: false }))).toBe(1);
Expand Down
Loading