Skip to content

Add option for not verifying SSL during S3 reading and writing - #27

Merged
KristianHMoller merged 7 commits into
dmidk:mainfrom
KristianHMoller:feature/no_verify_ssl
Oct 23, 2026
Merged

KristianHMoller merged 7 commits into
dmidk:mainfrom
KristianHMoller:feature/no_verify_ssl

Conversation

@KristianHMoller

@KristianHMoller KristianHMoller commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

This PR adds the option to bypass SSL verification when reading from S3 by setting the environment variable AWS_VERIFY_SSL to False.

@KristianHMoller KristianHMoller changed the title Add option for not verifying ssl Add option for not verifying SSL when reading from S3 Oct 23, 2026
@KristianHMoller
KristianHMoller marked this pull request as ready for review October 23, 2026 10:29

@elbdmi elbdmi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Just one minor suggestion. The PR title and changelog could be updated to mention both S3 reading and writing.

Otherwise looks good!

@KristianHMoller KristianHMoller changed the title Add option for not verifying SSL when reading from S3 Add option for not verifying SSL when reading and writing from/to S3 Oct 23, 2026
@KristianHMoller KristianHMoller changed the title Add option for not verifying SSL when reading and writing from/to S3 Add option for not verifying SSL during S3 reading and writing Oct 23, 2026
@KristianHMoller

Copy link
Copy Markdown
Collaborator Author

Thanks a lot for the

@KristianHMoller
KristianHMoller merged commit 26fea30 into dmidk:main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants