Skip to content

Use tp_finalize slot to manage cache #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skirpichev wants to merge 2 commits into from
Closed

Use tp_finalize slot to manage cache #300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdfc02c
Use tp_finalize slot to manage cache
skirpichev Jul 2, 2026
b2b02ef
Merge branch 'master' into use-finalize-for-cache
skirpichev Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ MPZ_new(void)
if (global.freelist_size) {
res = global.freelist[--global.freelist_size];
(void)zz_set(0, &res->z);
Py_INCREF((PyObject *)res);
}
else {
#endif
Expand Down Expand Up @@ -607,16 +606,28 @@ new(PyTypeObject *type, PyObject *args, PyObject *keywds)
return new_impl(type, arg, base);
}

#ifdef ON_CPYTHON
static void
dealloc(PyObject *self)
finalize(PyObject *self)
{
MPZ_Object *u = (MPZ_Object *)self;

#ifdef ON_CPYTHON
if (global.freelist_size < MAX_FREELIST_SIZE
&& zz_sizeof(&u->z) <= MAX_FREELIST_SIZEOF
&& MPZ_CheckExact(self))
{
Py_INCREF(self);
}
}
#endif

static void
dealloc(PyObject *self)
{
MPZ_Object *u = (MPZ_Object *)self;

#ifdef ON_CPYTHON
if (PyObject_CallFinalizerFromDealloc(self)) {
global.freelist[global.freelist_size++] = u;
}
else {
Expand Down Expand Up @@ -1949,6 +1960,9 @@ PyTypeObject MPZ_Type = {
.tp_basicsize = sizeof(MPZ_Object),
.tp_new = new,
.tp_dealloc = dealloc,
#ifdef ON_CPYTHON
.tp_finalize = finalize,
#endif
.tp_repr = repr,
.tp_str = str,
.tp_richcompare = richcompare,
Expand Down
Loading