fix: Ensure neither point of an arc is at the center before trying to add an arc - #433
Closed
me-it-is wants to merge 1 commit into
Closed
fix: Ensure neither point of an arc is at the center before trying to add an arc#433me-it-is wants to merge 1 commit into
me-it-is wants to merge 1 commit into
Conversation
me-it-is
force-pushed
the
fix-index-out-of-bounds
branch
from
July 28, 2026 18:49
ff851c5 to
61e6fdf
Compare
Member
|
Thank you! This is superseded by #437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes dimforge/rapier#969 by making it so that both steps of adding an arc get skipped rather than just adding the vertices, eliminating the out of bounds index caused by missing vertices.