Repository navigation
build: move benchmark dependencies to bench/package.json - #15
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 633 633
=========================================
Hits 633 633
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open Dependabot alerts are almost all for hono and @hono/node-server, which are only used by the benchmark. This moves the benchmark's comparison adapters (@whatwg-node/server, hono and both @hono/node-server majors) into their own bench/package.json and lockfile, updated to the latest versions, so they are no longer in the root dependency tree. The remaining shell-quote and brace-expansion alerts are fixed by updating them in the root lockfile. npm audit is clean for both.
Run
npm --prefix bench cionce beforenpm run bench; the READMEs say so. Knip now treats bench as a separate workspace.To keep future bench alerts out of the Security tab, add a repository-level Dependabot rule that dismisses alerts for the manifest path bench/package-lock.json.