Repository navigation
computer: Slack echo of a web message names the owner, not usr_… - #1065
Merged
Merged
Conversation
|
View docs preview Docs hosted with Margin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages sent from the web now reach the runner over the wire, whose actor carries only the member id (
computer/src/wire/edge-auth.tsactorFor, name null). The runner'sactorOffalls back to the id, so the Slack thread showed*usr_x035…* from the web:.The echo now names the owner by their own name (
personName(owner), which the runner already has), and anyone else whose name is unknown as "Someone", never the id. Posting as the user (sayAs, #1060) is unchanged.Requested by @mohamed Habib in Slack.
Tests: new case in
api.test.ts; computer suite 1004/1004, tsc clean.