Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/specs/layout.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ A mode or selection change, or a kill confirmation, takes it down.

Chrome outside every Wall takes the chrome keyboard lease instead: the Workspace strip's rename editor, close confirmation, and tab menu live in the app bar, where `stopPropagation` cannot reach a capture-phase window listener. The Workspace branch is inert on a Wall with no Workspace id.

**Must leave Escape and Tab to IME composition in modal/popover focus traps and terminal-context dialogs, and Enter/Escape in shared inline editors** (`isComposingKey` in `lib/src/lib/dom.ts`).
**Must leave Escape and Tab to IME composition in modal/popover focus traps, and Enter/Escape in shared inline editors** (`isComposingKey` in `lib/src/lib/dom.ts`).

Source of truth: `useWallKeyboard` in `lib/src/components/wall/use-wall-keyboard.ts`; `acquireChromeKeyboardLease` in `lib/src/components/wall/chrome-keyboard-lease.ts`; `handleStrayKey` in `lib/src/components/wall/keyboard/handle-stray-key.ts`.

Expand Down
2 changes: 1 addition & 1 deletion docs/specs/security-supply-chain.rationale.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Why the release build keeps pnpm's runtime: `build.rs` bundles the `node` on `PA

What the `minimumReleaseAge` package rules are: the Renovate equivalent of the pnpm dependency cooldown window, applied per manager.

The pgstencil exception has a different gate: its release workflow stages a version only after a passing `security-audit` on the packaged commit, and a human approves the staged package with npm 2FA before it becomes public. The package carries that commit in `dist/provenance.json`; Hosted verifies matching clean commits for core and auth, and its audit checks npm-signed workflow attestations bind those bytes to that commit. The exclusion list is deliberately narrow so other dependencies retain the withdrawal window.
The pgstencil exception has a different gate: its release workflow stages a version only after a passing `security-audit` on the packaged commit, and a human approves the staged package with npm 2FA before it becomes public. The package carries that commit in `dist/provenance.json`; Hosted verifies matching clean commits for core, auth, and stripe, and its audit checks npm-signed workflow attestations bind those bytes to that commit. The exclusion list is deliberately narrow so other dependencies retain the withdrawal window.

Why the `vulnerabilityAlerts` cooldown is kept rather than dropped for speed: it guards the opposite threat from the alert itself — a compromised release that gets yanked within a day, which a reviewer reading a dependency diff cannot detect the way the ecosystem's own yank process can. Nothing here auto-merges, and the Dependabot alert already makes the vulnerability visible the moment it is published, so what the cooldown costs is a day before the remediation PR appears, not a day before anyone knows.

Expand Down
2 changes: 1 addition & 1 deletion docs/specs/terminal-context.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
- **Must hide a retained helper without terminating its PTY**; revealing or promoting reuses the same xterm element. Renderer resource lifetime follows `docs/specs/layout.md` → "Renderer".
- **Must keep a helper's directory independent of its source**, showing both locations prominently when they differ. Unknown directory state is not evidence of a match.
- **Must retain exited output**, offer Reset, and avoid automatic restart loops.
- **Must pause status and process-inspection polling while the context is hidden**, its Workspace out of view included. Reopening publishes current terminal status; source closure inspects work on demand.
- **Must pause exit and process-inspection polling while the context is hidden**, its Workspace out of view included. Reopening publishes a helper's exit; source closure inspects work on demand.

**Must make Reset an explicit discard**, confirmed first; under Labs it asks nothing and the old helper becomes a pending kill (`docs/specs/reopen.md` → "Labs: No-confirm delayed kill"), which the host stops counting as the source's one helper until a restore re-owns it. Cancellation changes nothing; confirmation disposes the old helper and launches a fresh one in the source's current directory.

Expand Down
1 change: 0 additions & 1 deletion dor-tools-builtin/viewer/image/icons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const paths = {
redo: <><path d="M11 3l3 3-3 3" /><path d="M13.5 6H6a3.5 3.5 0 0 0 0 7h4" /></>,
square: <rect x="3.5" y="3.5" width="9" height="9" fill="currentColor" />,
round: <circle cx="8" cy="8" r="4.5" fill="currentColor" />,
close: <path d="M4 4l8 8M12 4l-8 8" />,
};
export type IconName = keyof typeof paths;

Expand Down
4 changes: 2 additions & 2 deletions dor-tools-builtin/viewer/image/image.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* The image editor on the workbench's --vscode-* variables: two dense rows of
* chrome, then the canvas. It fills the box its host gives it. The options row
* never wraps, so switching tools never moves the canvas: as the editor
* chrome, then the canvas. It fills the box its host gives it. Above 500px the
* options row never wraps, so switching tools never moves the canvas: as the editor
* narrows, its readouts drop out first (the container queries at the end),
* with the host's controls marked `ie-optional`; Save's own enabled state
* still says whether there are edits. */
Expand Down
2 changes: 1 addition & 1 deletion website/src/components/SiteHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const STATIC_PAGE_HEADER_STYLE: React.CSSProperties = {
export const PRELAUNCH_NOTICE = "Pre-launch — word of mouth only, please. No top-level forum posts.";

type SiteHeaderProps = Omit<ComponentProps<typeof SharedSiteHeader>, "links" | "notice"> & {
/** Show the pre-launch strip (Home and the reference pages). */
/** Show the pre-launch strip (Home, the docs, and the policy pages). */
prelaunch?: boolean;
};

Expand Down
Loading