Repository navigation
fix(den): retire empty starter plugins wherever plugins are listed - #5770
Merged
Merged
Conversation
Manage > Plugins and My Library now run the same retirement as the marketplace list, so an older organization never shows the empty PDF Viewer or Legal examples. Adds a journey that seeds those starters and opens both pages. Signed-off-by: Jalil <reachjalil@gmail.com>
Signed-off-by: Jalil <reachjalil@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenWork evidence
Run details · Open the preview to inspect evidence and sandbox options. |
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of d97a821b0eebe7aedfb71054b84b1d6d0d6fa28f found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Older organizations no longer see the empty example plugins (PDF Viewer, Legal, …) on Manage › Plugins or in My Library.
What problem does it solve?
#5431 stopped seeding the name-only starter plugins and retires leftover copies, but only when something lists the organization's marketplaces. Manage › Plugins and My Library never do, so an admin of an older organization who opens Plugins first still sees "PDF Viewer · Nothing inside yet".
What was the situation before?
Retirement ran only inside
GET /v1/marketplaces.GET /v1/pluginsandGET /v1/me/librarylisted the untouched placeholders as active plugins. #5589 also removed the unit tests that covered retirement, so nothing exercised it.How is this implemented?
ee/apps/den-api/src/routes/org/plugin-system/store.ts:retireEmptyStarterPluginsruns the existing retirement whenever plugins or a member's plugin access are listed. When nothing is left to retire, it costs two indexed reads and no transaction.evals/worlds/den-retired-starter-plugins.ts: an older organization whose starter marketplace still holds empty PDF Viewer and Legal plugins, seeded by the system, plus a Sales starter someone filled in with a skill.evals/specs/den-retired-starter-plugins.e2e.test.ts: the admin opens Plugins, and a member opens My Library.What else changed?
none
Release note
Manage › Plugins and My Library no longer show the empty example plugins in organizations created before they were removed.
Evidence
evals/specs/den-retired-starter-plugins.e2e.test.ts— before: an older organization's Plugins page lists PDF Viewer and Legal with nothing inside; after: opening Plugins retires them, Sales stays for the admin and in Maya's My Library, and a reload keeps them gone.