Repository navigation
chore: run on Node 24 everywhere - #109
Merged
Merged
Conversation
GitHub-hosted runners now force JavaScript actions onto Node 24, and puppeteer 25 and release-it 21 need Node 22+. - Docker base alpine:3.20 -> 3.23 (Node 24.18.1, npm 11.11.0, Chromium 149) - Install chromium explicitly: on 3.23 chromium-swiftshader no longer pulls it in, so /usr/bin/chromium-browser was missing - Pin .nvmrc to 24 and the e2e service to node:24-alpine - @types/node ^22 -> ^24 - Bump every workflow action to its Node 24 major npm 11 in the image also accepts lockfiles that Dependabot writes with npm 11, which npm 10 rejected (missing optional peers). AI Assisted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
karolinelien
added
the
e2e
Chromium 149 on alpine:3.23 no longer falls back to SwiftShader for
WebGL automatically, so headless Chrome in the image had no WebGL
context. The Maps app then crashed ("Something went wrong"), its
download button never enabled, and every dashboard with a map timed
out with a 504. --enable-unsafe-swiftshader restores the same
SwiftShader renderer Chromium 131 used by default.
AI Assisted
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When every conversion fails, e2e/generated-html is never created and the cp in the failure step exited 1, so the scrape markdown logs were never uploaded as an artifact. AI Assisted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
karolinelien
force-pushed
the
chore/node-24
branch
from
October 23, 2026 07:43
389d3b6 to
9a4c551
Compare
|
karolinelien
marked this pull request as ready for review
October 23, 2026 07:47
HendrikThePendric
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
alpine:3.20→alpine:3.23(Node 24.18.1, npm 11.11.0, Chromium 149).chromiumis now installed explicitly, sincechromium-swiftshaderno longer pulls it in.--enable-unsafe-swiftshader: Chromium 149 no longer falls back to SwiftShader WebGL by default, so the Maps app crashed and every dashboard with a map timed out (504)..nvmrcpinned to24, e2e service onnode:24-alpine,@types/node^24.e2e/generated-htmlis missing, so scrape logs still get uploaded.How verified
tsc, eslint, prettier, 22/22 unit tests pass.AI Assisted
🤖 Generated with Claude Code