Skip empty data frames, update crates - #79
Merged
Conversation
frankdavid
approved these changes
Sep 3, 2026
There was a problem hiding this comment.
🔵 Needs a closer look
Dependency updates and HTTP/2 streaming behavior require final human review.
Pull request overview
Prevents invalid empty non-final HTTP/2 DATA frames and updates Rust dependencies.
Changes:
- Filters empty response chunks before frame emission.
- Adds tests for filtering and error propagation.
- Updates direct and transitive crates.
File summaries
| File | Description |
|---|---|
packages/ic-http-gateway-protocol/src/response/response_handler.rs |
Skips empty streamed DATA frames and adds tests. |
Cargo.toml |
Updates workspace dependency versions. |
Cargo.lock |
Locks updated transitive dependencies. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty (non-final) DATA frames violate HTTP/2 protocol and cause various problems with recent
h2crate versions