Repository navigation
Fix package and test parsing on Swift toolchains before 6.1 - #109
Merged
devxoul merged 1 commit intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With Swift 6.0.3 on Ubuntu 24.04,
swift buildat main (529bfcb) fails while loadingPackage.swift:After removing that argument-list trailing comma,
swift testreaches the same syntax error intestRethrows. Trailing commas in function calls require Swift 6.1+, while the package currently declares Swift tools 5.0. This prevents consumers with an older toolchain from building the package, before any library code is compiled.Change
Remove the two argument-list trailing commas in the package manifest and existing test. Array/dictionary trailing commas are unchanged. No API, deployment target, tools-version or runtime behavior changes. The Tuist configuration and its current toolchain requirements are untouched.
Validation
Using Swift 6.0.3, with isolated HOME/config/cache/temp directories:
swift buildand all 7 existingswift testtests pass.with, reference identity/mutationthen/with,do, collection conformances, NSObject/OperationQueue, JSONEncoder/JSONDecoder round-trip, and throwing closures through all three public methods.git diff --checkpasses.Apple-platform Tuist/Xcode simulator checks were not run on this Windows/WSL host. Swift 5.x itself was not tested; the observed failure and repair are on 6.0.3. The existing README installation corrections in #95/#97 and actor-isolation work in #107 are separate and are not duplicated here.