Skip to content

Privacy manifest - #104

Open
zeroskylian wants to merge 4 commits into
devxoul:mainfrom
zeroskylian:master
Open

zeroskylian wants to merge 4 commits into
devxoul:mainfrom
zeroskylian:master

Conversation

@zeroskylian

Copy link
Copy Markdown

Add Privacy manifest

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment-target increases break existing SwiftPM consumers, and CocoaPods installations still omit the manifest. The UserDefaults declaration also needs to reflect Then’s own API usage.

Verification was static at head 9b6becb; builds, tests, and archive/privacy-report validation were not run.

Comment thread Package.swift Outdated
Comment thread Package.swift
Comment thread Sources/PrivacyInfo.xcprivacy Outdated

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three prior blockers remain at bb62d77: deployment requirements increased further, CocoaPods still omits the manifest, and unsupported UserDefaults reasons remain declared. Verification was static; builds and consumer archives were not validated.

Comment thread Package.swift
Comment thread Package.swift
Comment thread Sources/PrivacyInfo.xcprivacy Outdated

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform-floor objection is withdrawn: the supplied PackageDescription deprecations reasonably justify the chosen minimums. Thanks for the correction, and sorry for the repeated pushback.

Two previously reported concerns remain at bb62d77:

  • Then.podspec still declares no resources or resource bundles, so CocoaPods installations omit the privacy manifest. Add a uniquely named resource_bundles entry and verify inclusion in a consumer archive.
  • The manifest still declares UserDefaults reasons CA92.1 and 1C8F.1, although Then’s executable implementation does not access UserDefaults. Leave NSPrivacyAccessedAPITypes empty unless Then itself uses a required-reason API.

Archive validation was not performed.

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both remaining concerns are resolved at 03aabb7: CocoaPods now includes the privacy manifest through a resource bundle, and the unsupported UserDefaults declarations are removed. The deployment-target objection remains withdrawn.

Verification was static; builds, consumer archives, and privacy reports were not validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant