Skip to content

fix(android): the body scrolls from the room beside its column (0.11.1) - #163

Merged
jlc488 merged 2 commits into
mainfrom
fix/body-column-scroll-gutter
Nov 18, 2026
Merged

jlc488 merged 2 commits into
mainfrom
fix/body-column-scroll-gutter

Conversation

@jlc488

@jlc488 jlc488 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What

On a wide window (an unfolded Fold, a tablet) DdsBodyColumn is centered with room at each side. Only the column scrolled, so a drag that started in that room did nothing; Qooroo users noticed it on an unfolded phone.

  • DdsBodyColumn: the whole area scrolls (verticalScroll on the full-width box); the column keeps ddsBody(max), the Body tag and contentPadding. The box passes its height down as the column's least (propagateMinConstraints) and wrapContentWidth lets go of the least width, so a short body is still as tall as the area (a weighted spacer still fills it) and max still holds. ddsScreenContent(paneTitle) is unchanged and still on the outer box.
  • The sign-in sheet's list scrolls across the sheet's whole width.
  • Checked DdsPaneList, DdsBottomSheet, the rail and the dialog text: they scroll their full width already.
  • Version 0.11.1, CHANGELOG (en/ko, plus the missing 0.11.0 entry), README install lines.

Verified locally

  • New device tests in FrameOnDeviceTest: aDragInTheRoomBesideTheBodyScrollsIt was red before the fix (scroll value 0), green after; aWeightedSpacerInTheBodyFillsTheRoomLeft guards the height.
  • :dds-compose:connectedDebugAndroidTest on SM-F971N: 205 tests, 0 failures.
  • CI's Android build (testDebugUnitTest, lint, assembleRelease, catalog) and verify:source:stage1-2/3-4: green.

On a wide window (an unfolded phone, a tablet) DdsBodyColumn sits in the
middle with room at each side, and only the column itself scrolled, so a
drag that started in that room did nothing. The whole area now scrolls;
the column keeps its width, place, padding and the Body tag.

The area passes its height down as the column's least so a short body is
still as tall as the area and a weighted spacer fills what is left. A first
attempt passed the least width down too (propagateMinConstraints alone),
which overrode widthIn(max) and made the body full width; wrapContentWidth
lets go of the least width only.

The sign-in sheet's list now scrolls across the sheet's whole width as well.

Tests: a drag in the room beside the body scrolls it (red before the fix:
scroll value 0), and a weighted spacer still fills a short body.
… asks for

The release in #162 raised dds-auth's optional peer to @devslab/dds-react
^0.35.1, but the packed-consumer fixture still pinned 0.29.2, so npm stops
with ERESOLVE and verify:auth:release fails on every run since.
@jlc488

jlc488 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Added a second commit: verify:auth:release failed with ERESOLVE on both runs because #162 raised dds-auth's peer to @devslab/dds-react ^0.35.1 while packages/dds-auth/consumer/package.json still pinned 0.29.2. Bumped the fixture to 0.35.1; pnpm run verify:auth:release passes locally.

@jlc488
jlc488 merged commit 32630a8 into main Nov 18, 2026
3 checks passed
@jlc488
jlc488 deleted the fix/body-column-scroll-gutter branch November 18, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant