Repository navigation
fix(android): the body scrolls from the room beside its column (0.11.1) - #163
Merged
Merged
Conversation
On a wide window (an unfolded phone, a tablet) DdsBodyColumn sits in the middle with room at each side, and only the column itself scrolled, so a drag that started in that room did nothing. The whole area now scrolls; the column keeps its width, place, padding and the Body tag. The area passes its height down as the column's least so a short body is still as tall as the area and a weighted spacer fills what is left. A first attempt passed the least width down too (propagateMinConstraints alone), which overrode widthIn(max) and made the body full width; wrapContentWidth lets go of the least width only. The sign-in sheet's list now scrolls across the sheet's whole width as well. Tests: a drag in the room beside the body scrolls it (red before the fix: scroll value 0), and a weighted spacer still fills a short body.
… asks for The release in #162 raised dds-auth's optional peer to @devslab/dds-react ^0.35.1, but the packed-consumer fixture still pinned 0.29.2, so npm stops with ERESOLVE and verify:auth:release fails on every run since.
Contributor
Author
|
Added a second commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a wide window (an unfolded Fold, a tablet)
DdsBodyColumnis centered with room at each side. Only the column scrolled, so a drag that started in that room did nothing; Qooroo users noticed it on an unfolded phone.DdsBodyColumn: the whole area scrolls (verticalScrollon the full-width box); the column keepsddsBody(max), theBodytag andcontentPadding. The box passes its height down as the column's least (propagateMinConstraints) andwrapContentWidthlets go of the least width, so a short body is still as tall as the area (a weighted spacer still fills it) andmaxstill holds.ddsScreenContent(paneTitle)is unchanged and still on the outer box.DdsPaneList,DdsBottomSheet, the rail and the dialog text: they scroll their full width already.Verified locally
FrameOnDeviceTest:aDragInTheRoomBesideTheBodyScrollsItwas red before the fix (scroll value 0), green after;aWeightedSpacerInTheBodyFillsTheRoomLeftguards the height.:dds-compose:connectedDebugAndroidTeston SM-F971N: 205 tests, 0 failures.testDebugUnitTest, lint, assembleRelease, catalog) andverify:source:stage1-2/3-4: green.