Repository navigation
chore(solid): raise solid-js to 1.9.19 - #161
Merged
Merged
Conversation
Solid 1.9.19 depends on seroval ~1.6.11 / seroval-plugins ~1.6.8, so consumers of dds-solid, site-kit, dds-table and dds-table-solid no longer need a pnpm override to escape the vulnerable seroval 1.6.4 that 1.9.15 brought in. Dependency and peer pins move together, along with the contract tests and release scripts that assert the exact pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
solid-js 1.9.15 pulled in seroval 1.6.4 (vulnerable). Solid 1.9.19 depends on
seroval ~1.6.11/seroval-plugins ~1.6.8. Consumers (e.g. Qooroo) currently pin seroval with a pnpm override; after this release they can drop it.What
solid-js1.9.15 → 1.9.19 in dependencies and peerDependencies: root, compatibility-canary, dds-solid, dds-table, dds-table-solid, site-kit.Not in scope
seroval 1.6.4 is still in this repo's lockfile via
@tanstack/router-core/ start-*-core (dev deps and site-kit's optional TanStack peers). That's a TanStack pin, not solid-js; consumers on TanStack Start need a TanStack bump separately.Verified locally
verify:source:stage1-2/3-4,verify:canary:{dependencies,test,build},verify:foundation:core,verify:solid:{test,release},verify:table:{test,release},verify:site-kit:{i18n,ui,release}(hydration incl. dev-build condition tests: 13/13),verify:release,verify— all green.