Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f2a3e91
Validate every Terraform module and root configuration of a repository
devpro Nov 12, 2026
dcd6db5
Warn about outdated and vulnerable Terraform providers
devpro Nov 12, 2026
3b7272f
List the directories of an outdated provider without a leading comma
devpro Nov 12, 2026
6067fa7
Lint each Terraform configuration with the nearest TFLint file and wa…
devpro Nov 12, 2026
3fcf4f1
Test the rootfs scan type of the Trivy action on its own
devpro Nov 12, 2026
a02ec8a
Bump the pinned tools and add a script that lists available updates
devpro Nov 12, 2026
02f21d3
Explain the vulnerable provider warning of the Terraform fixture and …
devpro Nov 12, 2026
ed7baf8
Run the IstarCI jobs in ubuntu-node and ubuntu-node-playwright, which…
devpro Nov 13, 2026
0f2bcb9
Build and test .NET Framework code and Windows container images on Wi…
devpro Nov 14, 2026
93d3944
Scan a Windows image with Grype once built without push, as Trivy fin…
devpro Nov 14, 2026
9f9dd61
Scan a folder of a Windows image with Grype, copied out in seconds, w…
devpro Nov 14, 2026
2e051e8
Install the Windows build of Syft on a Windows runner, where the Linu…
devpro Nov 14, 2026
a12dcc0
Check the SBOM of the Windows Syft test with PowerShell, as a Windows…
devpro Nov 15, 2026
b2a7fec
Assign the PATH of the Windows Syft install before exporting it, so a…
devpro Nov 15, 2026
1bf39e9
Bump Helm to v4.3.2, actions/setup-java to v6.3.0, Checkov to 3.4.5 a…
devpro Nov 16, 2026
45bc542
Check the pipx, npx and ShellCheck pins of the reusable workflows for…
devpro Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/adopt-workflow-parts/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Safety before convenience, and fewer dependencies over more.
- `istarci run <sha>` retries a run that must run again (daemon restart, change to `~/.istarci/config.yml`), never right after a commit.
- A command over the 600 second tool limit is moved to the background, against the foreground rule:
`timeout 590 istarci wait` then call it again while the run is going.
- `.istarci.yml` of a consumer sets the runner image per job (`ghcr.io/devpro/debian-node-playwright` for browser tests),
- `.istarci.yml` of a consumer sets the runner image per job (`ghcr.io/devpro/ubuntu-node-playwright` for browser tests),
the jobs needing Docker,
and `skipJobs` for jobs that must never run on the developer machine (kind's privileged node, a QEMU registration in the kernel).
- The global ignores of image scans live in `~/.istarci/config.yml`, each with a reason and an expiry.
Expand Down
64 changes: 62 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,21 @@ jobs:
fi
done

# A Windows image is built on the Windows runner alone, and a CI run pushes nothing.
test-windows-container-publication:
name: "Test / Container publication reusable workflow, a Windows image without push"
uses: ./.github/workflows/reusable-container-publication.yml
with:
push: false
scan: true
scan-path: C:\Windows\System32\drivers\etc
image-definition: test/fixtures/container/windows/Dockerfile
image-path: localhost
image-name: windows-test
image-tag: ${{ github.run_id }}
image-platform: ""
windows-runner: windows-2025

test-container-build-push-arm64:
name: "Test / Container build-push action on an arm64 runner"
runs-on: ubuntu-24.04-arm
Expand Down Expand Up @@ -731,6 +746,31 @@ jobs:
jq -e '.bomFormat == "CycloneDX" and (.components | length > 0)' sbom-image-test.cdx.json
jq -e '[.packages[].name] | index("playwright-fixture") and (index("node-fixture") | not)' sbom-exclude-test.spdx.json

test-syft-generate-sbom-windows:
name: "Test / Syft generate-sbom action on Windows"
runs-on: windows-2025
timeout-minutes: 20
steps:
- name: Clone repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- name: Generate SBOM for a directory, one folder left out
uses: ./actions/syft/generate-sbom
with:
exclude-paths: node
target-path: test/fixtures
output-file: sbom-exclude-test.spdx.json
upload-artifact: "false"
# PowerShell reads the JSON, as a Windows runner image may lack jq.
- name: Verify SBOM was generated
shell: pwsh
run: |
syft version
if ($LASTEXITCODE -ne 0) { exit 1 }
$names = (Get-Content -Raw sbom-exclude-test.spdx.json | ConvertFrom-Json).packages.name
if (-not ($names -contains 'playwright-fixture') -or ($names -contains 'node-fixture')) { exit 1 }

test-trivy-scan:
name: "Test / Trivy scan action"
runs-on: ubuntu-latest
Expand Down Expand Up @@ -791,17 +831,29 @@ jobs:
scan-type: config
target: test/fixtures/terraform
ignore-file: test/fixtures/trivy/missing.yaml
- name: Verify SARIF report was generated and the findings failed the scans
# The metadata of an installed Python package, a version with known vulnerabilities, stands for the binaries and packages of a directory.
- name: Scan the installed packages of a directory with Trivy
uses: ./actions/trivy/scan
with:
scan-type: rootfs
target: test/fixtures/trivy/rootfs
format: json
output-file: trivy-rootfs.json
severity: HIGH,CRITICAL
- name: Verify the reports were generated and the findings failed the scans
env:
EXPIRED_OUTCOME: ${{ steps.trivy-expired.outcome }}
FINDING_OUTCOME: ${{ steps.trivy-finding.outcome }}
MISSING_IGNORE_FILE_OUTCOME: ${{ steps.trivy-missing-ignore-file.outcome }}
run: |
jq -e '.version == "2.1.0"' trivy-test.sarif
jq -e '[.Results[] | select(.Type == "python-pkg") | .Vulnerabilities[].VulnerabilityID] | any(. == "CVE-2019-11324")' trivy-rootfs.json
[ "$FINDING_OUTCOME" = failure ]
[ "$EXPIRED_OUTCOME" = failure ]
[ "$MISSING_IGNORE_FILE_OUTCOME" = failure ]

# The fixture locks the latest release of hashicorp/local, so a "Vulnerable provider" warning on it comes from the Go version and modules HashiCorp built it with.
# It is expected, shows the provider scan works, and goes away with a new release of the provider once the lock files are updated with terraform init -upgrade.
test-terraform-quality:
name: "Test / Terraform quality reusable workflow"
uses: ./.github/workflows/reusable-terraform-quality.yml
Expand Down Expand Up @@ -838,6 +890,14 @@ jobs:
secrets:
sonar-token: ${{ secrets.SONAR_TOKEN }}

# The fixture mixes a project of the old format restored from packages.config and an SDK one, as .NET Framework code being migrated does.
test-windows-dotnet-framework-quality:
name: "Test / .NET Framework quality reusable workflow"
uses: ./.github/workflows/reusable-dotnet-framework-quality.yml
with:
solution: Fixture.Framework.sln
working-directory: test/fixtures/dotnet-framework

test-dotnet-build-test:
name: "Test / .NET build-test action writes results, coverage and reports"
runs-on: ubuntu-latest
Expand Down Expand Up @@ -1057,7 +1117,7 @@ jobs:
FIXTURE_VALUE=extra
mongodb-enabled: true
task-enabled: true
terraform-version: 1.17.1
terraform-version: 1.17.2
test-script: test:coverage
working-directory: test/fixtures/node

Expand Down
108 changes: 96 additions & 12 deletions .github/workflows/reusable-container-publication.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Reusable - Container publication
# description: |
# Builds a new container image with Docker and pushes it to a registry
# With push false, the images are only built, so a CI pipeline checks the packaging with the same code, and no credentials
# Make sure to add (needed by cosign):
# ```
# permissions:
Expand All @@ -16,6 +17,21 @@ on:
type: string
required: false
default: "docker.io"
push:
description: Push the images and put them under the tag, which is otherwise left to a later run, the registry credentials being then not read
type: boolean
required: false
default: true
scan:
description: Scan the Windows image with Grype once built, failing on a critical vulnerability, which needs push false since a pushed image is removed from the runner
type: boolean
required: false
default: false
scan-path:
description: Folder of the Windows image the scan reads alone (for example C:\app), in seconds, the whole image when empty, which takes minutes for the gigabytes of its base layers
type: string
required: false
default: ""
create-latest:
description: "Create latest tag?"
type: boolean
Expand Down Expand Up @@ -43,7 +59,7 @@ on:
type: string
required: true
image-platform:
description: Platforms to build, emulated with QEMU on operating-system, unless arm64-runner is set
description: Linux platforms to build, emulated with QEMU on operating-system, unless arm64-runner is set, none when empty
type: string
required: false
default: "linux/amd64,linux/arm64"
Expand All @@ -52,6 +68,11 @@ on:
type: string
required: false
default: ""
windows-runner:
description: Windows runner label building windows/amd64 (for example "windows-2025"), for the Windows version of that runner, put under the tag beside the Linux platforms, none when empty
type: string
required: false
default: ""
job-name:
description: Job name
type: string
Expand Down Expand Up @@ -79,21 +100,23 @@ on:
default: "."
secrets:
container-registry-username:
description: Container registry username
required: true
description: Container registry username, needed to push
required: false
container-registry-password:
description: Container registry password
required: true
description: Container registry password, needed to push
required: false
secret-vars:
description: "Additional environment variables"
required: false

jobs:
build-emulated:
name: ${{ inputs.job-name }} build (emulated)
if: ${{ inputs.arm64-runner == '' }}
if: ${{ inputs.arm64-runner == '' && inputs.image-platform != '' }}
runs-on: ${{ inputs.operating-system }}
timeout-minutes: ${{ inputs.timeout-minutes }}
outputs:
digest: ${{ steps.build.outputs.digest }}
steps:
- name: Set secret variables
shell: bash
Expand Down Expand Up @@ -121,6 +144,7 @@ jobs:
path: workflow-parts
persist-credentials: false
- name: Login to container registry
if: ${{ inputs.push }}
env:
REGISTRY: ${{ inputs.container-registry }}
REGISTRY_USERNAME: ${{ secrets.container-registry-username }}
Expand All @@ -132,13 +156,15 @@ jobs:
uses: ./workflow-parts/actions/qemu/setup
with:
platforms: ${{ inputs.image-platform }}
# The action puts the platforms together under the tag once each is pushed.
# The action puts the platforms together under the tag once each is pushed, and the Windows image joins them later under another one.
- name: Build and push container image
id: build
uses: ./workflow-parts/actions/container/build-push
with:
push: ${{ inputs.push }}
image-definition: ${{ inputs.image-definition }}
image-repository: ${{ env.IMAGE_REPOSITORY }}
image-tag: ${{ inputs.image-tag }}
image-tag: ${{ inputs.windows-runner != '' && format('{0}-linux', inputs.image-tag) || inputs.image-tag }}
platforms: ${{ inputs.image-platform }}
build-arguments: ${{ inputs.extra-build-arguments }}
working-directory: ${{ inputs.working-directory }}
Expand Down Expand Up @@ -177,6 +203,7 @@ jobs:
path: workflow-parts
persist-credentials: false
- name: Login to container registry
if: ${{ inputs.push }}
env:
REGISTRY: ${{ inputs.container-registry }}
REGISTRY_USERNAME: ${{ secrets.container-registry-username }}
Expand All @@ -186,6 +213,7 @@ jobs:
id: build
uses: ./workflow-parts/actions/container/build-push
with:
push: ${{ inputs.push }}
image-definition: ${{ inputs.image-definition }}
image-repository: ${{ env.IMAGE_REPOSITORY }}
image-tag: ${{ inputs.image-tag }}-linux-amd64
Expand Down Expand Up @@ -227,6 +255,7 @@ jobs:
path: workflow-parts
persist-credentials: false
- name: Login to container registry
if: ${{ inputs.push }}
env:
REGISTRY: ${{ inputs.container-registry }}
REGISTRY_USERNAME: ${{ secrets.container-registry-username }}
Expand All @@ -236,19 +265,70 @@ jobs:
id: build
uses: ./workflow-parts/actions/container/build-push
with:
push: ${{ inputs.push }}
image-definition: ${{ inputs.image-definition }}
image-repository: ${{ env.IMAGE_REPOSITORY }}
image-tag: ${{ inputs.image-tag }}-linux-arm64
platforms: linux/arm64
build-arguments: ${{ inputs.extra-build-arguments }}
working-directory: ${{ inputs.working-directory }}

# The Windows engine builds only its own platform, on the Windows version of its runner.
build-windows:
name: ${{ inputs.job-name }} build (windows/amd64)
if: ${{ inputs.windows-runner != '' }}
runs-on: ${{ inputs.windows-runner }}
timeout-minutes: ${{ inputs.timeout-minutes }}
outputs:
digest: ${{ steps.build.outputs.digest }}
steps:
- name: Clone repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- name: Checkout workflow parts
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
repository: devpro/github-workflow-parts
# The caller being this repository, the actions under test are those of the commit under test.
ref: ${{ github.repository == 'devpro/github-workflow-parts' && github.sha || inputs.workflow-parts-version }}
path: workflow-parts
persist-credentials: false
- name: Login to container registry
if: ${{ inputs.push }}
shell: pwsh
env:
REGISTRY: ${{ inputs.container-registry }}
REGISTRY_USERNAME: ${{ secrets.container-registry-username }}
REGISTRY_PASSWORD: ${{ secrets.container-registry-password }}
run: |
$env:REGISTRY_PASSWORD | docker login $env:REGISTRY --username $env:REGISTRY_USERNAME --password-stdin
exit $LASTEXITCODE
- name: Build and push container image under the tag of its platform
id: build
uses: ./workflow-parts/actions/container/build-push
with:
push: ${{ inputs.push }}
image-definition: ${{ inputs.image-definition }}
image-repository: ${{ env.IMAGE_REPOSITORY }}
image-tag: ${{ inputs.image-tag }}-windows-amd64
platforms: windows/amd64
build-arguments: ${{ inputs.extra-build-arguments }}
working-directory: ${{ inputs.working-directory }}
# Grype rather than Trivy, which finds no package in a Windows image, where Grype reads the version of every .NET assembly and Windows binary.
- name: Scan container image with Grype
if: ${{ inputs.scan }}
uses: ./workflow-parts/actions/grype/scan
with:
image: ${{ env.IMAGE_REPOSITORY }}:${{ inputs.image-tag }}-windows-amd64
image-path: ${{ inputs.scan-path }}

# The platforms built on runners of their own are only put under the tag here, so that the image a tag names is complete.
publication:
name: ${{ inputs.job-name }}
needs: [build-emulated, build-amd64, build-arm64]
needs: [build-emulated, build-amd64, build-arm64, build-windows]
# One build path is skipped by design, which an implicit success() would take for a failure.
if: ${{ !cancelled() && !contains(needs.*.result, 'failure') }}
if: ${{ inputs.push && !cancelled() && !contains(needs.*.result, 'failure') }}
runs-on: ${{ inputs.operating-system }}
timeout-minutes: ${{ inputs.timeout-minutes }}
steps:
Expand All @@ -261,15 +341,19 @@ jobs:
path: workflow-parts
persist-credentials: false
- name: Login to container registry
if: ${{ inputs.push }}
env:
REGISTRY: ${{ inputs.container-registry }}
REGISTRY_USERNAME: ${{ secrets.container-registry-username }}
REGISTRY_PASSWORD: ${{ secrets.container-registry-password }}
run: echo "$REGISTRY_PASSWORD" | docker login "$REGISTRY" --username "$REGISTRY_USERNAME" --password-stdin
- name: Tag the image of every platform
if: ${{ inputs.arm64-runner != '' }}
if: ${{ inputs.arm64-runner != '' || inputs.windows-runner != '' }}
env:
DIGESTS: ${{ needs.build-amd64.outputs.digest }} ${{ needs.build-arm64.outputs.digest }}
# A build skipped by design gives no digest, so only the builds that ran are put together.
DIGESTS: >-
${{ needs.build-amd64.outputs.digest }} ${{ needs.build-arm64.outputs.digest }}
${{ inputs.windows-runner != '' && needs.build-emulated.outputs.digest || '' }} ${{ needs.build-windows.outputs.digest }}
run: |
sources=()
for digest in $DIGESTS; do
Expand Down
Loading
Loading