#2183: dynamically generate form fields for selected commandlet - #2233
Open
Hiepiscus wants to merge 15 commits into
Open
#2183: dynamically generate form fields for selected commandlet#2233Hiepiscus wants to merge 15 commits into
Hiepiscus wants to merge 15 commits into
Conversation
…let-view' into 2182-basic-structure-for-commandlet-view
… selected commandlet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2183
Introduces dynamic form generation for commandlets. Instead of using a static input field, the UI now creates appropriate form fields based on the properties of the selected commandlet for a more flexible configuration experience.
Show more lines
Implemented changes:
PropertyFormFieldFactory(new): create appropriate UI based on commandlet:TextFieldfor positional parameters and named optionsCheckBoxfor boolean flagsTextFieldwith aScrollPane+VBoxin the FXML layoutonCommandletSelected()listener to regenerate the form on selection changerunCommandlet()to read property values from generated form fieldsTesting instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
AppLauncherCommandletsRunChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal