#2181: Merge VSCodium plugins folder to VSCode

[samuelkos17]

This PR fixes #2181

Implemented changes:

• Added a new property excluded-editions in the .properties of plugins that can be set with a list of comma-separated names of versions of IDEs. To make this change future-proof the filter for the new property is implemented in the installPlugins()-method of the PluginBasedCommandlet-class. This means that it can be used for other IDEs besides VSCode and VSCodium.
• Added a new field excludedEditions to the ToolPluginDescriptor-record matching the new property of the plugins
• "Removed" the getPluginsConfigPath()-method of the Vscode-class so that both VSCodium and VSCode share the same folder for the plugins. However to guarantee backward-compatibility, the method can optionally be changed so that if 'settings/vscodium/plugins/' exists and 'settings/vscode/plugings/' has no VSCodium-specific overrides the plugins in VSCodium directory are installed instead.
• Added tests in VscodeTest.java.
• The PR for the ide-settings repository can be found here: #95

---

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1. Run the new tests in 'VscodeTest.java'

---

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summarizes what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
  with internal
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Coverage Report for CI Build 30462283487

Coverage increased (+0.02%) to 72.611%

Details

• Coverage increased (+0.02%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 18 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

18 previously-covered lines in 3 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java	10	86.98%
com/devonfw/tools/ide/tool/plugin/ToolPluginDescriptor.java	4	86.89%
com/devonfw/tools/ide/tool/vscode/Vscode.java	4	84.31%

---

Coverage Stats

Relevant Lines:	17005
Covered Lines:	12874
Line Coverage:	75.71%
Relevant Branches:	7607
Covered Branches:	4997
Branch Coverage:	65.69%
Branches in Coverage %:	Yes
Coverage Strength:	3.21 hits per line

---

💛 - Coveralls

[hohwille]

@samuelkos17 just as a first quick feedback while this is still in team review:
I very much like your idea of the excluded-editions property as CSV.
This is a very generic solution idea that can be useful for any kind of IDE and perfectly helps us for the current use-case to exclude some plugins from VSCodium. 👍

[laert-ll]

Thanks for your work! Nice, clean solution. I added some comments with some suggested changes, most of them being rather aesthetic. Also, you can create a PR in ide-settings to remove the vscodium plugins folder as well and link it to this PR.

[samuelkos17]

Thanks for your work! Nice, clean solution. I added some comments with some suggested changes, most of them being rather aesthetic. Also, you can create a PR in ide-settings to remove the vscodium plugins folder as well and link it to this PR.

Thanks for the review @laert-ll . I've did the clean up and added a test for the CSV parsing as you suggested