#1784 implement java fx based progress bars for the GUI - #1935
Conversation
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
…t-for-gui' into devonfw#1785-implement-modals-in-idecontext
- Added functionality, that selecting a different project now switches the IdeContext to the new project.
…plementation' into devonfw#1802-state-management-implementation
…r other ui feature branches
- Added Task overview window - added ListView that allows to manage concurrent tasks
…g progress -> better performance and higher reliability
- added DI for IdeGuiStateManager.switchContext
…reading the list of workspaces/projects instead of reading those from the UI
…nager, when switchContext(Path rootDirectory, ...) is called.
- taskids are now strings, based on UUID.randomUUID() - The TaskOverviewWindow is now displayed directly above the layout node that opens it - progress units are now shown in TaskOverviewWindow
This reverts commit 6f92d93.
…plementation' into devonfw#1802-state-management-implementation
…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter
… getInstance()) (see previous commit)
|
@KarimALotfy i think i might know, why you didnt get the progress bars when launching via |
…t-JavaFX-based-progress-bars-for-the-GUI # Conflicts: # CHANGELOG.adoc
…ent-JavaFX-based-progress-bars-for-the-GUI # Conflicts: # CHANGELOG.adoc
…t-JavaFX-based-progress-bars-for-the-GUI # Conflicts: # CHANGELOG.adoc # gui/src/main/java/com/devonfw/ide/gui/App.java # gui/src/main/java/com/devonfw/ide/gui/MainController.java # gui/src/main/resources/com/devonfw/ide/gui/main-view.fxml # gui/src/test/java/com/devonfw/ide/gui/AppBaseTest.java
hohwille
left a comment
There was a problem hiding this comment.
@laim2003 thanks for this PR. Great work that you added JavaFx progress bar support. 👍
I could add some review feedback change requests regarding packaging/naming conventions and consistency but this PR is pending for too long and it is adding great progress (and some cleanups) that other PRs want to base on.
Therefore I will merge this. I will either create some nice-to-have cleanup story or discuss via chat about some small naming improvements... But lets rather finally go head with our GUI and make progress first and perfection second ;)
…-bars-for-the-GUI
…-bars-for-the-GUI
This PR fixes #1784
This PR depends on #1802
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalTesting instructions
ide gui