Make daemon overlay launch and lifecycle ownership explicit - #406
Merged
Merged
Conversation
- Run the daemon overlay fixture as the test binary itself: a startup hook runs the production readiness handshake, and a child that exits before readiness is the same binary launched under a dedicated name. The launch error text stays as it was; per-candidate failures stay on a typed error. - Port the GTK popup Wayland proxy to Rust, reading message layouts from the protocol tables compiled into wayland-client and wayland-protocols. - Move the process-site, config-writer, and shared-dependency guards to Rust tests in tests/repository_guards, run by every cargo test, retire the C# copies, and add a guard that keeps Python out. - Make version check, bump, and release tags C# only, keeping the packaging-hotfix rules, and restore the code-health report's status lines. - Require the .NET SDK for tools/lint-and-test.sh, which runs the same plan as ci lint-and-test, and drop Python from Nix inputs and CI packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make overlay launch inputs and lifecycle transitions explicit, while preserving existing daemon behavior. Remove all Python from the repository: test fixtures are Rust, source guards are Rust tests, and release tooling is C#.
Changes
OverlayLifecycle.OverlayChildOwner; remove raw child-controller access from daemon callers.Python removal
delete_id, cleans up its process group, and reads message layouts from the protocol tables compiled intowayland-clientandwayland-protocols.tests/repository_guards, run by everycargo test, each with regression cases for the escapes it forbids. They keep every rule of the scripts they replace; process sites now recognise test code by its#[cfg(test)]module chain, and config writers again rejectascasts. The weaker C# copies are retired.no_python.rskeeps Python from coming back.version check --release-versionand the packaging-hotfix rules; the shell and Python versions are deleted. Nix inputs and CI package lists no longer include Python.tools/lint-and-test.shneeds the .NET SDK selected byglobal.jsonand runs the same steps asci lint-and-test. Without .NET,cargo teststill runs the Rust guards; that is Cargo validation, not the complete gate.Regression coverage
show_overlay, including argument/environment delivery, hide, restart, and natural retirement.tools/test-gtk-widgets.sh, fourEXECUTEDmarkers).