Repository navigation
fix: logging, facilitator config and CDP auth - #44
Merged
Merged
Conversation
SergeevDmitry
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
console.error, which let an unauthenticated request forge log lines.facilitator.urlwith a query string or fragment is refused at config load. The client appends its routes to the URL, so every payment failed with such a URL.apiKeySecretnow stopsstartinstead of failing every paid request with 503. A PEM secret with JSON-escaped\nis accepted. Tokens are signed only for the route the SDK reads.validateandstartwarn whenmerchant.publicBaseUrlis not an http(s) URL, and whenredelivery.requiredhas no effect because the resource is served on MPP./readyturned 503.Behavior changes
validateandstartnow refuse two configs that 2.7.0 accepted: a facilitator URL with a query string or fragment, and an unusable CDP secret. Neither config could complete a payment. ThepublicBaseUrlandredelivery.requiredchecks only warn, and those configs still load.