Add some allocation-related attributes - #458
Open
capitalistspz wants to merge 6 commits into
Open
Conversation
`WUT_ALLOC_SIZE` was left off `MEMAllocFromExpHeapEx` because the allocated region may be resized via `MEMResizeForMBlockExpHeap`, but is always accessed via the same pointer. Some functions had to have the free and allocate function order swapped because the two-parameter `malloc` attribute relies on declaration order
… `MEMAllocFromFrmHeapEx`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WUT_ALLOC_SIZEenables checks validating allocation sizes for the allocation result type, and should (but doesn't currently seem to) check out of bounds accesses.WUT_FREED_BYenables checks for pointers being freed by the wrong function.WUT_ALLOC_ALIGNEDandWUT_MALLOCshould enable some optimisations, though the attribute does nothing with negative alignment values (which can be provided to theMEMAllocFrom*Heapfunctions).WUT_ALLOC_SIZEisn't applied toMEMAllocFromExpHeapExbecauseMEMResizeForMBlockExpHeapcan change the allocation size.A few functions had to be swapped around because
WUT_FREED_BYneeds the free function to be declared first.