compiler: Simplify fission - #2973
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
===========================================
- Coverage 82.99% 58.93% -24.07%
===========================================
Files 257 203 -54
Lines 53823 34961 -18862
Branches 4609 4077 -532
===========================================
- Hits 44671 20604 -24067
- Misses 8339 13381 +5042
- Partials 813 976 +163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d44b2e3 to
d0379ba
Compare
EdCaunt
left a comment
There was a problem hiding this comment.
One minor comment but seems reasonable
| def scope(self): | ||
| return Scope(exprs=self.exprs) | ||
|
|
||
| @cached_property |
There was a problem hiding this comment.
that likely was for homogeneity I didn't even think about that, but yes, you're right.
If you don't mind, I'd drop it (along with the other useless ones in that class) in the subsequent PR
7f8019b to
90d71dc
Compare
90d71dc to
72a5fdf
Compare
without this simplification (which was done in 2021, now it seems unneeded, AFAICT based on the tests I've managed to run...) a new test in PRO would fail
I don't see the logic behind it, so unless CI/CD complains, I'd drop it
It might also be a leftover from some other tweaks that was later undone... not sure!