Repository navigation
fix(report): a step skipped by its when: is reported skipped - #275
Open
luka-vladika-happening-xyz wants to merge 1 commit into
Open
luka-vladika-happening-xyz wants to merge 1 commit into
luka-vladika-happening-xyz wants to merge 1 commit into
Conversation
A runFlow or runScript whose when: was false did not run, but the report said passed, the same as a step that ran, so a reader of the report could not tell the two apart. Maestro reports such a step as skipped (it throws CommandSkipped in Orchestra.kt's runFlowCommand and runScriptCommand). The step is now skipped in the report, at the top level and inside a runFlow, retry or repeat, and counts as skipped instead of passed. The console still prints it with a check mark: OnStepComplete gets passed for any step that did not fail, so a skipped step is not printed as a failure. That also applies to a step skipped by its platform:, which was printed with a cross.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
runFloworrunScriptwhosewhen:is false does not run, but the report saidpassed, the same as a step that ran, so a reader of the report (the HTML report, or a tool reading the JSON) could not tell a skipped branch from one that ran. Maestro reports such a step as skipped:runFlowCommandandrunScriptCommandinOrchestra.ktthrowCommandSkipped, and its console prints SKIPPED.The step is now
skippedin the report, at the top level and inside arunFlow,retryorrepeat, and counts as skipped instead of passed.The console still prints it with a check mark:
OnStepCompletenow getspassedfor any step that did not fail, so a skipped step is not printed as a failure. That also applies to a step skipped by itsplatform:, which was printed with a cross.TestWhenFalseIsReportedSkippedruns a flow with a falsewhen:on arunScriptand arunFlow, at the top level and inside arunFlow, and checks each command's status in the flow's JSON and the flow's step counts. On main it fails: every step ispassed, 5 passed and 0 skipped. Checked on an Android emulator: maestro-runner and Maestro 2.11.0 now mark the same steps skipped.go test -race ./...passes apart from the CDP package, which hangs launching Chrome on this Mac and also does on main; golangci-lint v2.13.2: 0 issues.