Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ updates:
update-types:
- minor
- patch
ignore:
# ncc (0.45, the latest) compiles through TypeScript's JS compiler API,
# which TypeScript 7, the native Go port, does not ship: `pnpm build`
# dies with "Cannot read properties of undefined (reading 'fileExists')".
# Remove this once an ncc release supports TypeScript 7.
- dependency-name: typescript
versions: [">= 7"]

# GitHub Actions used by our workflows.
- package-ecosystem: github-actions
Expand Down
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,21 @@ jobs:

- name: Run unit tests
run: pnpm test

# Dependabot PRs only run this workflow, so the build has to be checked
# here too. Without it the TypeScript 7 bump merged green and only broke
# in the Release workflow's dist rebuild on main.
- name: Build dist
run: pnpm build

# ncc exits 0 when it can't resolve an import. It bundles a stub that
# throws "Cannot find module" when the action runs instead. That is what
# the ESM-only @actions/core 3 and @actions/github 9 did to a CommonJS
# build: a 36 kB dist/index.js that failed on its first line.
- name: Check every import was bundled
run: |
if grep -q webpackMissingModule dist/index.js; then
echo "::error::dist/index.js has imports ncc could not resolve:"
grep -o "Cannot find module '[^']*'" dist/index.js | sort -u
exit 1
fi
Loading
Loading