Skip to content

fix: ncc build typescript 7 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 2 commits into from
Oct 5, 2026
Merged

fix: ncc build typescript 7 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1ec919
chore: pin typescript to 5.9 until ncc supports TypeScript 7
finalerock44 Oct 5, 2026
117bf6f
ci: build dist on every PR
finalerock44 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ updates:
update-types:
- minor
- patch
ignore:
# ncc (0.45, the latest) compiles through TypeScript's JS compiler API,
# which TypeScript 7, the native Go port, does not ship: `pnpm build`
# dies with "Cannot read properties of undefined (reading 'fileExists')".
# Remove this once an ncc release supports TypeScript 7.
- dependency-name: typescript
versions: [">= 7"]

# GitHub Actions used by our workflows.
- package-ecosystem: github-actions
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,9 @@ jobs:

- name: Run unit tests
run: pnpm test

# Dependabot PRs only run this workflow, so the build has to be checked
# here too. Without it the TypeScript 7 bump merged green and only broke
# in Build Source on main.
- name: Build dist
run: pnpm build
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"devDependencies": {
"@types/node": "^26.6.4",
"@vercel/ncc": "^0.45.0",
"typescript": "^7.0.2",
"typescript": "^5.9.3",
"vitest": "^5.0.3"
},
"pnpm": {
Expand Down
213 changes: 6 additions & 207 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading