Repository navigation
fix(device): drop Android API 29-31 from the --android-api-level help - #227
Merged
Merged
Conversation
The API stops accepting API levels 29, 30 and 31 on 19 October 2026 (they were only ever offered on pixel-6, which keeps 32-37). Validation already comes from the compatibility endpoint at run time, so this enum only feeds the flag's help text; it no longer advertises levels that are rejected. src/types/generated/schema.types.ts is left for the next full regeneration: regenerating now would also pull in unrelated API drift, including a device slug that is still gated to dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API stops accepting API levels 29, 30 and 31 on 19 October 2026 (they were only ever offered on pixel-6, which keeps 32-37). Validation already comes from the compatibility endpoint at run time, so this enum only feeds the flag's help text; it no longer advertises levels that are rejected.
src/types/generated/schema.types.ts is left for the next full regeneration: regenerating now would also pull in unrelated API drift, including a device slug that is still gated to dev.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test