Repository navigation
fix(validation): mirror the API's Pixel 7 / API 36 Android default - #225
Merged
Merged
Conversation
The API's default Android API level moves from 34 to 36 on 19 October 2026 (the device stays Pixel 7), so a device-only request is now checked against 36. `--android-device pixel-10` on its own is accepted, as the API accepts it. pixel-7 / API 36 has no Google Play image, and the API does not apply the global default to a Play request that omits one half: it picks the value that makes the pair a Play cell. The check now fills the omitted half the same way, so `--google-play --android-device pixel-8` or `--google-play --android-api-level 36` is no longer refused here when the API would run it. A device with no Play image, or a level no Play device offers, is still refused with the same messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API's default Android API level moves from 34 to 36 on 19 October 2026 (the device stays Pixel 7), so a device-only request is now checked against 36.
--android-device pixel-10on its own is accepted, as the API accepts it.pixel-7 / API 36 has no Google Play image, and the API does not apply the global default to a Play request that omits one half: it picks the value that makes the pair a Play cell. The check now fills the omitted half the same way, so
--google-play --android-device pixel-8or--google-play --android-api-level 36is no longer refused here when the API would run it. A device with no Play image, or a level no Play device offers, is still refused with the same messages.What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test