Repository navigation
ci(claude-review): keep the review in the foreground and fail if nothing is posted - #224
Merged
Merged
Conversation
…ing is posted Port of dcd's fixes. Headless runs ended the turn early (backgrounded reviewers, denied tools), so no comment was posted and the job still went green. PR #223's review stopped after 10 turns with 3 permission denials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…round # Conflicts: # .github/workflows/claude-code-review.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Claude review job often finishes green without posting anything. On #223 it stopped after 10 turns (about a minute), had 3 tool calls denied, and left no comment.
dcdhit the same problem and fixed it. This PR copies those fixes.Changes
ghcommand and read-onlygitcommands (diff,log,show), which should stop the denials.show_full_output), so the next failure is easier to diagnose.dcd's.This repo's existing skip rules (Dependabot, release-please and back-merge PRs) are unchanged.
dcd's rule forproductionPRs isn't copied, because this repo has no always-open promotion PR.Heads-up
claude-reviewis a required check. After this merges, a review that posts nothing blocks the merge instead of passing silently.Testing
The workflow file is valid YAML, and the check step matches
dcd's exactly. This PR's ownclaude-reviewrun uses the new workflow, so it is the first real test.🤖 Generated with Claude Code