[nmgaston]

NOTE: Don't merge without console and cloud fixes.

PR Checklist

• Unit Tests have been added for new changes
• API tests have been updated if applicable
• All commented code has been removed
• If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Hardens BIOS status handling for the RPE flow when BIOS responses are delayed, so the UI/state management doesn’t incorrectly fail or show stale status while waiting.

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

device-management-toolkit/console#1338

[Copilot]

🟡 Changes recommended

Polling can mix device results after route changes and repeatedly display transient timeout alerts.

2 open issues

• Polling continues against the wrong device after route changes · New
• Suppress transient polling timeout notifications during BIOS delays · New

What changed in this PR

Improves Remote Platform Erase feedback by distinguishing request submission from confirmed BIOS completion.

Changes:

• Adds enterprise BIOS-status polling and pending-state controls.
• Limits SSD passwords to 32 characters and 64 UTF-8 bytes.
• Updates tests and localized messages.

File	Description
src/​models/​models.ts	Adds erase-status model.
src/​assets/​i18n/​sv.json	Updates Swedish messages.
src/​assets/​i18n/​ru.json	Updates Russian messages.
src/​assets/​i18n/​nl.json	Updates Dutch messages.
src/​assets/​i18n/​ja.json	Updates Japanese messages.
src/​assets/​i18n/​it.json	Updates Italian messages.
src/​assets/​i18n/​he.json	Updates Hebrew messages.
src/​assets/​i18n/​fr.json	Updates French messages.
src/​assets/​i18n/​fi.json	Updates Finnish messages.
src/​assets/​i18n/​es.json	Updates Spanish messages.
src/​assets/​i18n/​en.json	Updates English messages.
src/​assets/​i18n/​de.json	Updates German messages.
src/​assets/​i18n/​ar.json	Updates Arabic messages.
src/​app/​devices/​remote-platform-erase/​remote-platform-erase.component.ts	Adds polling and password validation.
src/​app/​devices/​remote-platform-erase/​remote-platform-erase.component.spec.ts	Tests polling and password limits.
src/​app/​devices/​remote-platform-erase/​remote-platform-erase.component.html	Shows progress and disables pending actions.
src/​app/​devices/​devices.service.ts	Adds status endpoint request.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

A delayed submission response can restart polling for the previous device after navigation, blocking the current device’s controls and displaying the wrong outcome.

1 open issue

• Stale erase response polls old device after input changes · New

2 resolved since last review

• Suppress transient polling timeout notifications during BIOS delays
• Polling continues against the wrong device after route changes

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The destructive workflow needs human validation against the Console API contract, and a delayed-response lifecycle issue remains unresolved.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Guard pending erase response after component destruction

src/​app/​devices/​remote-platform-erase/​remote-platform-erase.component.ts:330

If the component is destroyed while setRemoteEraseOptions is pending, its subscription still handles the response. The device ID remains unchanged, so this guard passes, shows a submission snackbar, and calls watchEraseResult after destruction. Check destroyRef.destroyed before these side effects, and add a regression test that destroys the component before the submission response arrives; the existing destruction test only covers an already-started watcher.

1 resolved since last review

• Stale erase response polls old device after input changes

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The destructive erase workflow needs human integration validation against the Console BIOS-status API and across both deployment flavors.

No open issues 🎉

_{Review effort: Balanced}

[rsdmike]

thanks for this. @nmgaston! Two things I see. First, the removed setAmtFeatures(..., { ocr, rpe: true }) call was what turned OCR back on after console sets the boot service to an OCR-disabled state, so users with OCR enabled will lose it after an erase. Second, the 5 minute limit can show "Unable to confirm" as an error after an erase that potentially worked, because a reboot plus a long SSD erase can run past 5 minutes or hide the pending state from the polls. A longer or configurable limit and a warning instead of an error would fix that. Small cleanups: csmeEraseSuccess and eraseSuccess are now unused in all the i18n files, and the 5000/10000/300000 values in watchEraseResult should be named constants.

[nmgaston]

thanks for this. @nmgaston! Two things I see. First, the removed setAmtFeatures(..., { ocr, rpe: true }) call was what turned OCR back on after console sets the boot service to an OCR-disabled state, so users with OCR enabled will lose it after an erase. Second, the 5 minute limit can show "Unable to confirm" as an error after an erase that potentially worked, because a reboot plus a long SSD erase can run past 5 minutes or hide the pending state from the polls. A longer or configurable limit and a warning instead of an error would fix that. Small cleanups: csmeEraseSuccess and eraseSuccess are now unused in all the i18n files, and the 5000/10000/300000 values in watchEraseResult should be named constants.

@rsdmike Thanks for the feedback. I've fixed all of the mentioned issues.