Repository navigation
feat: return a 409 error when a device reaches max 8 wireless profiles - #1326
Open
choonkeat1986 wants to merge 1 commit into
Open
choonkeat1986 wants to merge 1 commit into
choonkeat1986 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
+ Coverage 62.17% 62.21% +0.04%
==========================================
Files 159 159
Lines 13414 13429 +15
==========================================
+ Hits 8340 8355 +15
Misses 5074 5074 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The mandatory Postman contract update for the new capacity-limit response is missing.
1 open finding
What changed in this PR
Adds an eight-profile capacity check to Console’s device wireless-profile creation flow, returning HTTP 409 when full.
Changes:
- Rejects additions before certificate installation, excluding AMT “User Settings” entries from the count.
- Maps the capacity error to HTTP 409 and documents the limit.
- Adds use-case and HTTP-handler tests.
| File | Description |
|---|---|
| internal/usecase/devices/wifiprofile.go | Adds profile counting and capacity rejection. |
| internal/usecase/devices/wifiprofile_test.go | Tests capacity boundaries and certificate-side-effect prevention. |
| internal/controller/openapi/devicemanagement.go | Documents capacity and duplicate conflicts. |
| internal/controller/httpapi/v1/wifiprofile.go | Returns HTTP 409 for capacity errors. |
| internal/controller/httpapi/v1/wifiprofile_test.go | Tests the capacity-conflict status. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
choonkeat1986
force-pushed
the
jira#1095
branch
from
October 16, 2026 06:31
1a2366c to
3649c1f
Compare
choonkeat1986
force-pushed
the
jira#1095
branch
from
October 16, 2026 06:39
3649c1f to
3f21d32
Compare
choonkeat1986
requested review from
graikhel-intel,
lim-chris,
madhavilosetty-intel,
rsdmike and
sudhir-intc
October 16, 2026 13:58
rsdmike
reviewed
Oct 16, 2026
rsdmike
self-requested a review
October 16, 2026 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.