Repository navigation
Conversation
With AUTH_DISABLED=true, flip the UI bundle's authDisabled flag so it skips the login page. Auth off takes precedence over OAuth injection. Moves the bundle patching into applyUIConfig so it can be unit tested.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Required companion UI PR #3577 remains unmerged, so bundled integration needs human verification.
0 open findings
What changed in this PR
Updates Console’s UI bundle configuration to skip login when authentication is disabled.
Changes:
- Enables
authDisabledahead of OAuth configuration. - Extracts bundle patching into
applyUIConfig. - Adds tests for authentication modes and precedence.
| File | Description |
|---|---|
| internal/controller/httpapi/ui.go | Extracts configuration patching and adds auth-disabled handling. |
| internal/controller/httpapi/ui_test.go | Tests auth-disabled and OAuth flag combinations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
+ Coverage 62.24% 62.42% +0.18%
==========================================
Files 159 159
Lines 13417 13423 +6
==========================================
+ Hits 8351 8379 +28
+ Misses 5066 5044 -22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With AUTH_DISABLED=true, flip the UI bundle's authDisabled flag so it skips the login page. Auth off takes precedence over OAuth injection. Moves the bundle patching into applyUIConfig so it can be unit tested.
depends on device-management-toolkit/sample-web-ui#3577