Repository navigation
feat: add isElevated and heciAvailable to deviceInfo - #1306
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
=======================================
Coverage 62.16% 62.17%
=======================================
Files 159 159
Lines 13401 13414 +13
=======================================
+ Hits 8331 8340 +9
- Misses 5070 5074 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sinchubhat
force-pushed
the
issue1613-rpc-go
branch
from
October 14, 2026 03:58
30fbf20 to
fa12b7e
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Exports discard heciAvailable:false, and the required Postman API contract was not updated.
2 open findings
What changed in this PR
Adds privilege and HECI availability signals to DeviceInfo for rpc-go discovery reporting.
Changes:
- Persists and merges both nullable boolean fields.
- Exposes them through APIs, exports, and OpenAPI examples.
- Adds serialization and merge tests.
| File | Description |
|---|---|
internal/usecase/devices/usecase.go |
Adds partial-update field setters. |
internal/usecase/devices/usecase_private_test.go |
Tests false-value merging. |
internal/entity/dto/v1/export.go |
Adds fields to export DTOs. |
internal/entity/dto/v1/device.go |
Adds fields to DeviceInfo. |
internal/entity/dto/v1/device_test.go |
Tests JSON round-tripping. |
internal/controller/openapi/devices.go |
Updates OpenAPI examples. |
internal/controller/httpapi/v1/export.go |
Maps fields into device exports. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sinchubhat
force-pushed
the
issue1613-rpc-go
branch
from
October 14, 2026 05:09
fa12b7e to
c08a380
Compare
Accept, persist, and expose isElevated and heciAvailable in DeviceInfo so Console can distinguish unprivileged rpc-go discovery runs from genuine non-AMT/non-vPro devices. Related to device-management-toolkit/rpc-go#1613
sinchubhat
force-pushed
the
issue1613-rpc-go
branch
from
October 14, 2026 05:33
c08a380 to
99f0ad2
Compare
sinchubhat
marked this pull request as ready for review
October 14, 2026 05:48
sudhir-intc
approved these changes
Oct 16, 2026
DevipriyaS17
approved these changes
Oct 16, 2026
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept, persist, and expose isElevated and heciAvailable in DeviceInfo so Console can distinguish unprivileged rpc-go discovery runs from genuine non-AMT/non-vPro devices.
Related to device-management-toolkit/rpc-go#1613
Companion PR:
device-management-toolkit/rpc-go#1614