Repository navigation
#315 fix: keep the selected holiday subdivision in the reservation overview - #319
Merged
developeregrem merged 3 commits intoOct 20, 2026
Conversation
The subdivision was never stored on change and was overwritten with "all" on page load before the stored value was restored. A country change now resets the subdivision and reloads the table only once the new country's subdivisions are in place.
…ubdivision-setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315
Problem
In the reservation overview, the subdivision chosen under Settings → Holidays fell back to "all" after a page reload:
loadTableSettings()wrote the form's default ("all") to localStorage before restoring the stored value, so the stored value was always overwritten.Fix
The change is limited to
assets/controllers/reservations_controller.js, plus a line in the 4.14.0 release notes.