Repository navigation
Fix empty release notes in the release pipeline - #10
Merged
Merged
Conversation
GoReleaser reads --release-notes in its changelog pipe, so disabling the changelog also dropped the notes: v0.1.0 was created with an empty body. Enable the pipe (given a notes file it does not generate a Git log), and check the published release has notes, since CI snapshot builds skip this pipe and could not catch it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.0 draft release was created with empty notes.
Cause:
.goreleaser.yamlhadchangelog.disable: true. GoReleaser reads--release-notesinside its changelog pipe, so disabling that pipe silently dropped the notes file (source). CI'srelease-checkruns in snapshot mode, which always skips this pipe, so it couldn't catch it.Fix:
Verified: ran
goreleaser release --skip=publish,validate --release-notes …on thev0.1.0tag with both configs. With the old one the changelog pipe never runs; with this one it does ("generating changelog").The v0.1.0 draft was repaired by hand (
gh release edit --notes-filewith the CHANGELOG section from the tag). This PR is for future releases.🤖 Generated with Claude Code